From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: <rtc-linux@googlegroups.com>
Cc: <linux-kernel@vger.kernel.org>, <julia.lawall@lip6.fr>,
Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format
Date: Mon, 17 Sep 2012 19:28:08 +0530 [thread overview]
Message-ID: <1347890294-28467-2-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com>
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++----
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c
index 7fa67d0..b44b2a1 100644
--- a/drivers/rtc/rtc-ds1672.c
+++ b/drivers/rtc/rtc-ds1672.c
@@ -37,8 +37,18 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm)
unsigned char buf[4];
struct i2c_msg msgs[] = {
- {client->addr, 0, 1, &addr}, /* setup read ptr */
- {client->addr, I2C_M_RD, 4, buf}, /* read date */
+ {
+ .addr = client->addr,
+ .flags = 0,
+ .len = 1,
+ .buf = &addr
+ }, /* setup read ptr */
+ {
+ .addr = client->addr,
+ .flags = I2C_M_RD,
+ .len = 4,
+ .buf = buf
+ }, /* read date */
};
/* read date registers */
@@ -99,8 +109,16 @@ static int ds1672_get_control(struct i2c_client *client, u8 *status)
unsigned char addr = DS1672_REG_CONTROL;
struct i2c_msg msgs[] = {
- {client->addr, 0, 1, &addr}, /* setup read ptr */
- {client->addr, I2C_M_RD, 1, status}, /* read control */
+ { .addr = client->addr,
+ .flags = 0,
+ .len = 1,
+ .buf = &addr
+ }, /* setup read ptr */
+ { .addr = client->addr,
+ .flags = I2C_M_RD,
+ .len = 1,
+ .buf = status
+ }, /* read control */
};
/* read control register */
--
1.7.5.4
next prev parent reply other threads:[~2012-09-17 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 13:58 [PATCH 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-17 13:58 ` Shubhrajyoti D [this message]
2012-09-18 1:44 ` [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format Ryan Mallon
2012-09-18 6:05 ` Shubhrajyoti
2012-09-18 6:10 ` Ryan Mallon
2012-09-17 13:58 ` [PATCH 2/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 3/7] " Shubhrajyoti D
2012-09-18 1:45 ` Ryan Mallon
2012-09-18 5:38 ` Shubhrajyoti
2012-09-18 1:51 ` Ryan Mallon
2012-09-18 5:40 ` Shubhrajyoti
2012-09-18 5:47 ` Ryan Mallon
2012-09-18 5:53 ` Julia Lawall
2012-09-17 13:58 ` [PATCH 4/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 5/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 6/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 7/7] " Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347890294-28467-2-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®