From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: <rtc-linux@googlegroups.com>
Cc: <linux-kernel@vger.kernel.org>, <julia.lawall@lip6.fr>,
Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: [PATCH 6/7] rtc: Convert struct i2c_msg initialization to C99 format
Date: Mon, 17 Sep 2012 19:28:13 +0530 [thread overview]
Message-ID: <1347890294-28467-7-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com>
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/rtc/rtc-s35390a.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c
index c9562ce..e8c835e 100644
--- a/drivers/rtc/rtc-s35390a.c
+++ b/drivers/rtc/rtc-s35390a.c
@@ -50,7 +50,7 @@ static int s35390a_set_reg(struct s35390a *s35390a, int reg, char *buf, int len)
{
struct i2c_client *client = s35390a->client[reg];
struct i2c_msg msg[] = {
- { client->addr, 0, len, buf },
+ { .addr = client->addr, .flags = 0, .len = len, .buf = buf },
};
if ((i2c_transfer(client->adapter, msg, 1)) != 1)
@@ -63,7 +63,7 @@ static int s35390a_get_reg(struct s35390a *s35390a, int reg, char *buf, int len)
{
struct i2c_client *client = s35390a->client[reg];
struct i2c_msg msg[] = {
- { client->addr, I2C_M_RD, len, buf },
+ { .addr = client->addr, .flags = I2C_M_RD, .len = len, .buf = buf },
};
if ((i2c_transfer(client->adapter, msg, 1)) != 1)
--
1.7.5.4
next prev parent reply other threads:[~2012-09-17 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 13:58 [PATCH 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format Shubhrajyoti D
2012-09-18 1:44 ` Ryan Mallon
2012-09-18 6:05 ` Shubhrajyoti
2012-09-18 6:10 ` Ryan Mallon
2012-09-17 13:58 ` [PATCH 2/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 3/7] " Shubhrajyoti D
2012-09-18 1:45 ` Ryan Mallon
2012-09-18 5:38 ` Shubhrajyoti
2012-09-18 1:51 ` Ryan Mallon
2012-09-18 5:40 ` Shubhrajyoti
2012-09-18 5:47 ` Ryan Mallon
2012-09-18 5:53 ` Julia Lawall
2012-09-17 13:58 ` [PATCH 4/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 5/7] " Shubhrajyoti D
2012-09-17 13:58 ` Shubhrajyoti D [this message]
2012-09-17 13:58 ` [PATCH 7/7] " Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347890294-28467-7-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®