From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Mukesh Rathor <mukesh.rathor@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.
Date: Thu, 18 Oct 2012 14:33:29 +0100 [thread overview]
Message-ID: <1350567209.2460.145.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1210181426090.2689@kaball.uk.xensource.com>
On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote:
> On Wed, 17 Oct 2012, Ian Campbell wrote:
> > We use XENMEM_add_to_physmap_range which is the preferred interface
> > for foreign mappings.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> It looks OK but there are few code style issues, please run the patch
> through checkpatch.
The only one I get is:
WARNING: please, no spaces at the start of a line
#83: FILE: include/xen/interface/memory.h:175:
+ uint16_t size;$
total: 0 errors, 1 warnings, 64 lines checked
The prevailing indentation in that file is 4 spaces so I think we should
ignore the warning in this case in the interests of consistency with the
surrounding code.
Ian.
next prev parent reply other threads:[~2012-10-18 13:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 11:31 [PATCH V2 0/6] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-17 11:32 ` [PATCH 1/6] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-18 13:11 ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 2/6] xen: arm: enable balloon driver Ian Campbell
2012-10-18 13:20 ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 3/6] xen: avoid use of vma->vm_private in xen_unmap_domain_mfn_range interface Ian Campbell
2012-10-17 11:32 ` [PATCH 4/6] xen: correctly use xen_pfn_t in remap_domain_mfn_range Ian Campbell
2012-10-18 13:23 ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-18 13:27 ` Stefano Stabellini
2012-10-18 13:33 ` Ian Campbell [this message]
2012-10-18 13:35 ` Stefano Stabellini
2012-10-18 13:47 ` Ian Campbell
2012-10-17 11:32 ` [PATCH 6/6] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Ian Campbell
2012-10-17 23:57 ` Mukesh Rathor
2012-10-18 7:20 ` Ian Campbell
2012-10-18 13:30 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350567209.2460.145.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®