mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Mukesh Rathor <mukesh.rathor@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 4/6] xen: correctly use xen_pfn_t in remap_domain_mfn_range.
Date: Thu, 18 Oct 2012 14:23:35 +0100	[thread overview]
Message-ID: <alpine.DEB.2.02.1210181422450.2689@kaball.uk.xensource.com> (raw)
In-Reply-To: <1350473532-15863-4-git-send-email-ian.campbell@citrix.com>

On Wed, 17 Oct 2012, Ian Campbell wrote:
> For Xen on ARM a PFN is 64 bits so we need to use the appropriate
> type here.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

In general every mfn/pfn type should be xen_pfn_t, we might have to do a
closer audit of the code.


>  arch/x86/xen/mmu.c    |    2 +-
>  include/xen/xen-ops.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 1c5812b..d779e96 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -2603,7 +2603,7 @@ static int remap_area_mfn_pte_fn(pte_t *ptep, pgtable_t token,
>  
>  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
>  			       unsigned long addr,
> -			       unsigned long mfn, int nr,
> +			       xen_pfn_t mfn, int nr,
>  			       pgprot_t prot, unsigned domid,
>  			       struct page **pages)
>  
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index 6a40253..dc63e80 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -26,7 +26,7 @@ void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
>  struct vm_area_struct;
>  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
>  			       unsigned long addr,
> -			       unsigned long mfn, int nr,
> +			       xen_pfn_t mfn, int nr,
>  			       pgprot_t prot, unsigned domid,
>  			       struct page **pages);
>  int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> -- 
> 1.7.2.5
> 

  reply	other threads:[~2012-10-18 13:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 11:31 [PATCH V2 0/6] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-17 11:32 ` [PATCH 1/6] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-18 13:11   ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 2/6] xen: arm: enable balloon driver Ian Campbell
2012-10-18 13:20   ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 3/6] xen: avoid use of vma->vm_private in xen_unmap_domain_mfn_range interface Ian Campbell
2012-10-17 11:32 ` [PATCH 4/6] xen: correctly use xen_pfn_t in remap_domain_mfn_range Ian Campbell
2012-10-18 13:23   ` Stefano Stabellini [this message]
2012-10-17 11:32 ` [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-18 13:27   ` Stefano Stabellini
2012-10-18 13:33     ` Ian Campbell
2012-10-18 13:35       ` Stefano Stabellini
2012-10-18 13:47         ` Ian Campbell
2012-10-17 11:32 ` [PATCH 6/6] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Ian Campbell
2012-10-17 23:57   ` Mukesh Rathor
2012-10-18  7:20     ` Ian Campbell
2012-10-18 13:30   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1210181422450.2689@kaball.uk.xensource.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.rathor@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®