From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: "benjamin.tissoires" <benjamin.tissoires@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 04/11] HID: hid-multitouch: support arrays for the split of the touches in a report
Date: Fri, 26 Oct 2012 10:44:20 +0200 [thread overview]
Message-ID: <1351241067-9521-5-git-send-email-benjamin.tissoires@gmail.com> (raw)
In-Reply-To: <1351241067-9521-1-git-send-email-benjamin.tissoires@gmail.com>
Win8 certification introduced the ability to transmit two X and two Y per
touch. The specification precises that it must be in an array, with a
report count == 2.
This test guarantees that we split the touches on the last element
in this array.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
---
drivers/hid/hid-multitouch.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 725d155..95562d8 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -577,12 +577,16 @@ static int mt_event(struct hid_device *hid, struct hid_field *field,
return 0;
}
- if (usage->hid == td->last_slot_field)
- mt_complete_slot(td, field->hidinput->input);
-
- if (field->index == td->last_field_index
- && td->num_received >= td->num_expected)
- mt_sync_frame(td, field->hidinput->input);
+ if (usage_index + 1 == field->report_count) {
+ /* we only take into account the last report
+ * of a field if report_count > 1 */
+ if (usage->hid == td->last_slot_field)
+ mt_complete_slot(td, field->hidinput->input);
+
+ if (field->index == td->last_field_index
+ && td->num_received >= td->num_expected)
+ mt_sync_frame(td, field->hidinput->input);
+ }
}
--
1.7.11.7
next prev parent reply other threads:[~2012-10-26 8:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 8:44 [PATCH v2 00/11] Win 8 support for digitizers Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 01/11] HID: hid-input: export hidinput_calc_abs_res Benjamin Tissoires
2012-10-29 18:57 ` Henrik Rydberg
2012-10-30 10:04 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 02/11] HID: core: fix unit exponent parsing Benjamin Tissoires
2012-10-29 19:05 ` Henrik Rydberg
2012-10-30 10:07 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 03/11] HID: hid-input: add usage_index argument in input_mapping and event Benjamin Tissoires
2012-10-29 19:25 ` Henrik Rydberg
2012-10-30 10:09 ` Benjamin Tissoires
2012-11-06 13:56 ` Benjamin Tissoires
2012-11-06 15:24 ` Jiri Kosina
2012-10-26 8:44 ` Benjamin Tissoires [this message]
2012-10-29 21:49 ` [PATCH v2 04/11] HID: hid-multitouch: support arrays for the split of the touches in a report Henrik Rydberg
2012-10-30 10:11 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 05/11] HID: hid-multitouch: get maxcontacts also from logical_max value Benjamin Tissoires
2012-10-29 21:52 ` Henrik Rydberg
2012-10-26 8:44 ` [PATCH v2 06/11] HID: hid-multitouch: support T and C for win8 devices Benjamin Tissoires
2012-10-29 22:00 ` Henrik Rydberg
2012-10-30 10:16 ` Benjamin Tissoires
2012-10-31 18:47 ` Henrik Rydberg
2012-10-26 8:44 ` [PATCH v2 07/11] HID: hid-multitouch: move ALWAYS_VALID quirk check Benjamin Tissoires
2012-10-29 22:16 ` Henrik Rydberg
2012-10-30 10:19 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 08/11] HID: hid-multitouch: fix Win 8 protocol Benjamin Tissoires
2012-10-29 22:19 ` Henrik Rydberg
2012-10-30 10:24 ` Benjamin Tissoires
2012-10-31 18:53 ` Henrik Rydberg
2012-11-02 14:18 ` Benjamin Tissoires
2012-11-04 20:54 ` Henrik Rydberg
2012-11-05 9:51 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 09/11] HID: hid-multitouch: support for hovering devices Benjamin Tissoires
2012-10-29 22:31 ` Henrik Rydberg
2012-10-30 10:43 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 10/11] HID: introduce Scan Time Benjamin Tissoires
2012-10-29 22:43 ` Henrik Rydberg
2012-10-30 10:54 ` Benjamin Tissoires
2012-10-31 19:16 ` Henrik Rydberg
2012-11-02 14:23 ` Benjamin Tissoires
2012-10-26 8:44 ` [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path Benjamin Tissoires
2012-10-29 22:57 ` Henrik Rydberg
2012-10-30 11:04 ` Benjamin Tissoires
2012-10-31 19:18 ` Henrik Rydberg
2012-11-05 12:57 ` Henrik Rydberg
2012-11-05 13:28 ` Benjamin Tissoires
2012-11-05 13:32 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351241067-9521-5-git-send-email-benjamin.tissoires@gmail.com \
--to=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome