* [PATCH] x86: remove dummy long from EFI stub
@ 2012-10-27 22:34 Cesar Eduardo Barros
2012-11-04 18:14 ` Matt Fleming
2012-11-16 19:45 ` Justen, Jordan L
0 siblings, 2 replies; 4+ messages in thread
From: Cesar Eduardo Barros @ 2012-10-27 22:34 UTC (permalink / raw)
To: x86
Cc: linux-kernel, Cesar Eduardo Barros, Jordan Justen, Matt Fleming,
H. Peter Anvin, Thomas Gleixner, Ingo Molnar
Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
boot stub support), but forgot to remove the dummy long used by that
reloc.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
| 3 ---
1 file changed, 3 deletions(-)
--git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
index 2a01744..8c132a6 100644
--- a/arch/x86/boot/header.S
+++ b/arch/x86/boot/header.S
@@ -476,6 +476,3 @@ die:
setup_corrupt:
.byte 7
.string "No setup signature found...\n"
-
- .data
-dummy: .long 0
--
1.7.11.7
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove dummy long from EFI stub
2012-10-27 22:34 [PATCH] x86: remove dummy long from EFI stub Cesar Eduardo Barros
@ 2012-11-04 18:14 ` Matt Fleming
2012-11-16 19:45 ` Justen, Jordan L
1 sibling, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2012-11-04 18:14 UTC (permalink / raw)
To: Cesar Eduardo Barros
Cc: x86, linux-kernel, Jordan Justen, H. Peter Anvin,
Thomas Gleixner, Ingo Molnar
On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Matt Fleming <matt.fleming@intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> ---
> arch/x86/boot/header.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
> setup_corrupt:
> .byte 7
> .string "No setup signature found...\n"
> -
> - .data
> -dummy: .long 0
This change seems fine to me. Jordan, would you mind ACKing this if
you're OK with it?
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove dummy long from EFI stub
2012-10-27 22:34 [PATCH] x86: remove dummy long from EFI stub Cesar Eduardo Barros
2012-11-04 18:14 ` Matt Fleming
@ 2012-11-16 19:45 ` Justen, Jordan L
2012-11-19 8:29 ` Matt Fleming
1 sibling, 1 reply; 4+ messages in thread
From: Justen, Jordan L @ 2012-11-16 19:45 UTC (permalink / raw)
To: Cesar Eduardo Barros
Cc: x86, linux-kernel, Matt Fleming, H. Peter Anvin, Thomas Gleixner,
Ingo Molnar, Rosenbaum, Lee G
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Lee also tested with Secure Boot. (Thanks Lee)
-Jordan
On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Matt Fleming <matt.fleming@intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> ---
> arch/x86/boot/header.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
> setup_corrupt:
> .byte 7
> .string "No setup signature found...\n"
> -
> - .data
> -dummy: .long 0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove dummy long from EFI stub
2012-11-16 19:45 ` Justen, Jordan L
@ 2012-11-19 8:29 ` Matt Fleming
0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2012-11-19 8:29 UTC (permalink / raw)
To: Justen, Jordan L
Cc: Cesar Eduardo Barros, x86, linux-kernel, H. Peter Anvin,
Thomas Gleixner, Ingo Molnar, Rosenbaum, Lee G
On Fri, 2012-11-16 at 11:45 -0800, Justen, Jordan L wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> Lee also tested with Secure Boot. (Thanks Lee)
Thanks guys. I've applied this patch.
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-19 8:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-27 22:34 [PATCH] x86: remove dummy long from EFI stub Cesar Eduardo Barros
2012-11-04 18:14 ` Matt Fleming
2012-11-16 19:45 ` Justen, Jordan L
2012-11-19 8:29 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®