* [PATCH] pwm: spear: Staticize spear_pwm_config()
@ 2012-11-09 11:52 Axel Lin
2012-11-09 11:53 ` Viresh Kumar
2012-11-09 11:58 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2012-11-09 11:52 UTC (permalink / raw)
To: Thierry Reding; +Cc: Shiraz Hashim, Viresh Kumar, linux-kernel
spear_pwm_config() is not referenced outside of this file, make it static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-spear.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index 6a8fd9b..83b21d9 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -76,8 +76,8 @@ static inline void spear_pwm_writel(struct spear_pwm_chip *chip,
writel_relaxed(val, chip->mmio_base + (num << 4) + offset);
}
-int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, int duty_ns,
- int period_ns)
+static int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
+ int duty_ns, int period_ns)
{
struct spear_pwm_chip *pc = to_spear_pwm_chip(chip);
u64 val, div, clk_rate;
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: spear: Staticize spear_pwm_config()
2012-11-09 11:52 [PATCH] pwm: spear: Staticize spear_pwm_config() Axel Lin
@ 2012-11-09 11:53 ` Viresh Kumar
2012-11-09 11:58 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2012-11-09 11:53 UTC (permalink / raw)
To: Axel Lin; +Cc: Thierry Reding, Shiraz Hashim, Viresh Kumar, linux-kernel
On 9 November 2012 17:22, Axel Lin <axel.lin@ingics.com> wrote:
> spear_pwm_config() is not referenced outside of this file, make it static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: spear: Staticize spear_pwm_config()
2012-11-09 11:52 [PATCH] pwm: spear: Staticize spear_pwm_config() Axel Lin
2012-11-09 11:53 ` Viresh Kumar
@ 2012-11-09 11:58 ` Thierry Reding
2012-11-09 11:59 ` Viresh Kumar
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2012-11-09 11:58 UTC (permalink / raw)
To: Axel Lin; +Cc: Shiraz Hashim, Viresh Kumar, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Fri, Nov 09, 2012 at 07:52:22PM +0800, Axel Lin wrote:
> spear_pwm_config() is not referenced outside of this file, make it static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-spear.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 6a8fd9b..83b21d9 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -76,8 +76,8 @@ static inline void spear_pwm_writel(struct spear_pwm_chip *chip,
> writel_relaxed(val, chip->mmio_base + (num << 4) + offset);
> }
>
> -int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, int duty_ns,
> - int period_ns)
> +static int spear_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
> + int duty_ns, int period_ns)
> {
> struct spear_pwm_chip *pc = to_spear_pwm_chip(chip);
> u64 val, div, clk_rate;
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pwm: spear: Staticize spear_pwm_config()
2012-11-09 11:58 ` Thierry Reding
@ 2012-11-09 11:59 ` Viresh Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2012-11-09 11:59 UTC (permalink / raw)
To: Thierry Reding; +Cc: Axel Lin, Shiraz Hashim, Viresh Kumar, linux-kernel
On 9 November 2012 17:28, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> Applied, thanks.
Aah.. That's pretty fast :)
within 5 minutes of posting the patch you got ACK and got applied too :)
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-09 11:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-09 11:52 [PATCH] pwm: spear: Staticize spear_pwm_config() Axel Lin
2012-11-09 11:53 ` Viresh Kumar
2012-11-09 11:58 ` Thierry Reding
2012-11-09 11:59 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®