mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kamal Mostafa <kamal@canonical.com>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>
Cc: David Solda <dso@cypress.com>, Troy Abercrombia <ta@cypress.com>,
	Dudley Du <dudl@cypress.com>,
	Cypress Semiconductor Corporation <customercare@cypress.com>,
	Kamal Mostafa <kamal@canonical.com>,
	Kyle Fazzari <git@status.e4ward.com>,
	Mario Limonciello <mario_limonciello@dell.com>,
	Tim Gardner <tim.gardner@canonical.com>,
	Herton Krzesinski <herton.krzesinski@canonical.com>
Subject: [PATCH v3 0/4] Cypress PS/2 Trackpad driver
Date: Thu, 29 Nov 2012 13:57:57 -0800	[thread overview]
Message-ID: <1354226281-3476-1-git-send-email-kamal@canonical.com> (raw)

This driver, submitted on behalf of Cypress Semiconductor Corporation and
additional contributors, provides support for the Cypress PS/2 Trackpad.

This [PATCH v3] version differs from my previous submitted version[1]:

  Patch #1 (cmdbuf to 8 bytes) and #3 (link in driver) are unchanged.

  Patch #2 (main driver), as recommended by Henrik Rydberg[2]:
  - use input_mt_assign_slots; drop cypress_cal_finger_id.
  - enable 2-finger-only SEMI_MT; drop cypress_simulate_fingers.
  - various code clean-ups.

  Henrik, does patch #2 appear to properly use assign_slots and SEMI_MT as
  you intended?  This SEMI_MT method does work (with 2 finger support only),
  but I'm not clear why we wouldn't want to handle >2 fingers also, so ...

  Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers
  (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again.

  If that functionality (support for >2 fingers) can be acheived in some
  better way, please advise.


Remaining known problems (assistance or advice appreciated):

  - Multitouch >2 fingers does not work after rmmod/insmod, and stops
    working after suspend/resume.  Restarting X fixes it in both cases.

  - cypress_reconnect() never actually works, so I disabled it; just let
    psmouse re-init the driver instead, which works and is what was ending
    up happenning anyway.


 -Kamal Mostafa <kamal@canonical.com>

[0] PATCH v1: http://www.spinics.net/lists/linux-input/msg23690.html
[1] PATCH v2: http://www.spinics.net/lists/linux-input/msg23718.html
[2] Henrik's review: http://www.spinics.net/lists/linux-input/msg23747.html



Cypress Semiconductor Corporation (2):
  input: Cypress PS/2 Trackpad psmouse driver
  input: Cypress PS/2 Trackpad link into psmouse-base

Kamal Mostafa (2):
  input: increase struct ps2dev cmdbuf[] to 8 bytes
  input: Cypress PS/2 Trackpad simulated multitouch

 drivers/input/mouse/Kconfig        |   10 +
 drivers/input/mouse/Makefile       |    1 +
 drivers/input/mouse/cypress_ps2.c  |  846 ++++++++++++++++++++++++++++++++++++
 drivers/input/mouse/cypress_ps2.h  |  231 ++++++++++
 drivers/input/mouse/psmouse-base.c |   32 ++
 drivers/input/mouse/psmouse.h      |    1 +
 include/linux/libps2.h             |    2 +-
 7 files changed, 1122 insertions(+), 1 deletion(-)
 create mode 100644 drivers/input/mouse/cypress_ps2.c
 create mode 100644 drivers/input/mouse/cypress_ps2.h

-- 
1.7.10.4


             reply	other threads:[~2012-11-29 21:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29 21:57 Kamal Mostafa [this message]
2012-11-29 21:57 ` [PATCH v3 1/4] input: increase struct ps2dev cmdbuf[] to 8 bytes Kamal Mostafa
2012-11-29 21:57 ` [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-12-03  3:20   ` Dudley Du
2012-12-03  5:57   ` Dudley Du
2012-12-03  6:31     ` Henrik Rydberg
2012-12-03  6:31       ` Dudley Du
2012-12-03  7:45   ` Henrik Rydberg
2012-12-03 17:04     ` Dmitry Torokhov
2012-12-05  2:22     ` Kamal Mostafa
2012-12-05  6:24       ` Dudley Du
2012-11-29 21:58 ` [PATCH v3 3/4] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa
2012-11-29 21:58 ` [PATCH v3 4/4] input: Cypress PS/2 Trackpad simulated multitouch Kamal Mostafa
2012-12-03  1:58   ` Dudley Du
2012-12-03  7:36 ` [PATCH v3 0/4] Cypress PS/2 Trackpad driver Dmitry Torokhov
2012-12-05  2:22   ` SEMI_MT vs. simulated mt (was Re: [PATCH v3 0/4] Cypress PS/2 Trackpad driver) Kamal Mostafa
2012-12-03  7:50 ` [PATCH v3 0/4] Cypress PS/2 Trackpad driver Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354226281-3476-1-git-send-email-kamal@canonical.com \
    --to=kamal@canonical.com \
    --cc=customercare@cypress.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dso@cypress.com \
    --cc=dudl@cypress.com \
    --cc=git@status.e4ward.com \
    --cc=herton.krzesinski@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=rydberg@euromail.se \
    --cc=ta@cypress.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®