mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kamal Mostafa <kamal@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	Dudley Du <dudl@cypress.com>
Cc: linux-kernel@vger.kernel.org, David Solda <dso@cypress.com>,
	Troy Abercrombia <ta@cypress.com>,
	Kyle Fazzari <git@status.e4ward.com>,
	Mario Limonciello <mario_limonciello@dell.com>,
	Herton Krzesinski <herton.krzesinski@canonical.com>,
	linux-input@vger.kernel.org,
	Tim Gardner <tim.gardner@canonical.com>
Subject: SEMI_MT vs. simulated mt (was Re: [PATCH v3 0/4] Cypress PS/2 Trackpad driver)
Date: Tue, 04 Dec 2012 18:22:18 -0800	[thread overview]
Message-ID: <1354674138.11174.86.camel@fourier> (raw)
In-Reply-To: <20121203073636.GA28682@core.coreip.homeip.net>

Hi Dmitry and Henrik-

Regarding SEMI_MT vs. "simulated multitouch" . . .

> > 
> >   Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers
> >   (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again.
> > 
> >   If that functionality (support for >2 fingers) can be acheived in some
> >   better way, please advise.


On Sun, 2012-12-02 at 23:36 -0800, Dmitry Torokhov wrote:
> You can still report true number of fingers on the pad via BTN_TOOL_*TAP
> while reporting the bounding box, the same way as Synaptics, Elantech,
> ALPS and Sentelic drivers are doing it.


On Mon, 2012-12-03 at 08:45 +0100, Henrik Rydberg wrote:
> +		ret = input_mt_init_slots(input, CYTP_MAX_MT_SLOTS,
> +			INPUT_MT_POINTER|INPUT_MT_DROP_UNUSED|INPUT_MT_TRACK);
> 
> Here, INPUT_MT_POINTER needs to be dropped; for semi-mt devices, the
> number of fingers is propagated separately using
> 
>    input_mt_report_finger_count(dev, finger_count_as_reported_by_the_device),
> 
> which conflicts with automatic handling of pointer logic.


Well...  The forthcoming PATCH v4 version now implements all that ^^ as
you requested, but it appears that my desktop (X with Unity desktop in
Ubuntu 12.10) does not actually respond to input_mt_report_finger_count
events (e.g. BTN_TOOL_TRIPLETAP).

I asked a colleague test a couple of other semi-mt touchpads (Synaptics
and ALPS) and we found the same result:  The desktop doesn't see >2
finger events with any of these semi-mt devices, even though
'input-events' does show that the BTN_TOOL_*TAP events are in the input
stream.  (Do other X desktops actually support BTN_TOOL_*TAP?)

I understand that this may be "a userspace problem", but from my
perspective the "simulated multitouch" patch is still necessary for >2
finger tap/drag.  I have left it in my PATCH v4 set for that reason
(patch 4/4; disabled by an ifdef).  It can be included and left
disabled, or enabled, or dropped as you see fit.

 -Kamal



  reply	other threads:[~2012-12-05  2:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29 21:57 [PATCH v3 0/4] Cypress PS/2 Trackpad driver Kamal Mostafa
2012-11-29 21:57 ` [PATCH v3 1/4] input: increase struct ps2dev cmdbuf[] to 8 bytes Kamal Mostafa
2012-11-29 21:57 ` [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-12-03  3:20   ` Dudley Du
2012-12-03  5:57   ` Dudley Du
2012-12-03  6:31     ` Henrik Rydberg
2012-12-03  6:31       ` Dudley Du
2012-12-03  7:45   ` Henrik Rydberg
2012-12-03 17:04     ` Dmitry Torokhov
2012-12-05  2:22     ` Kamal Mostafa
2012-12-05  6:24       ` Dudley Du
2012-11-29 21:58 ` [PATCH v3 3/4] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa
2012-11-29 21:58 ` [PATCH v3 4/4] input: Cypress PS/2 Trackpad simulated multitouch Kamal Mostafa
2012-12-03  1:58   ` Dudley Du
2012-12-03  7:36 ` [PATCH v3 0/4] Cypress PS/2 Trackpad driver Dmitry Torokhov
2012-12-05  2:22   ` Kamal Mostafa [this message]
2012-12-03  7:50 ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354674138.11174.86.camel@fourier \
    --to=kamal@canonical.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dso@cypress.com \
    --cc=dudl@cypress.com \
    --cc=git@status.e4ward.com \
    --cc=herton.krzesinski@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=rydberg@euromail.se \
    --cc=ta@cypress.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome