* [PATCH -next] f2fs: remove unused variable
@ 2012-12-02 13:11 Wei Yongjun
2012-12-02 23:12 ` Jaegeuk Kim
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-12-02 13:11 UTC (permalink / raw)
To: jaegeuk.kim; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The variables node_page and page_offset are initialized but never used
otherwise, so remove those unused variables.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
fs/f2fs/file.c | 2 --
fs/f2fs/dir.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index f5ae36d..69e05c6 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -30,7 +30,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
struct page *page = vmf->page;
struct inode *inode = vma->vm_file->f_path.dentry->d_inode;
struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
- struct page *node_page;
block_t old_blk_addr;
struct dnode_of_data dn;
int err;
@@ -50,7 +49,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
}
old_blk_addr = dn.data_blkaddr;
- node_page = dn.node_page;
if (old_blk_addr == NULL_ADDR) {
err = reserve_new_block(&dn);
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index 5975568..6891e45 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -509,13 +509,11 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct page *page,
}
if (bit_pos == NR_DENTRY_IN_BLOCK) {
- loff_t page_offset;
truncate_hole(dir, page->index, page->index + 1);
clear_page_dirty_for_io(page);
ClearPageUptodate(page);
dec_page_count(sbi, F2FS_DIRTY_DENTS);
inode_dec_dirty_dents(dir);
- page_offset = page->index << PAGE_CACHE_SHIFT;
f2fs_put_page(page, 1);
} else {
f2fs_put_page(page, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] f2fs: remove unused variable
2012-12-02 13:11 [PATCH -next] f2fs: remove unused variable Wei Yongjun
@ 2012-12-02 23:12 ` Jaegeuk Kim
0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2012-12-02 23:12 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, linux-kernel, linux-f2fs-devel
[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]
Merged.
Thanks,
Add CC: linux-f2fs-devel@lists.sourceforge.net
2012-12-02 (일), 08:11 -0500, Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variables node_page and page_offset are initialized but never used
> otherwise, so remove those unused variables.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> fs/f2fs/file.c | 2 --
> fs/f2fs/dir.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f5ae36d..69e05c6 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -30,7 +30,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
> struct page *page = vmf->page;
> struct inode *inode = vma->vm_file->f_path.dentry->d_inode;
> struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
> - struct page *node_page;
> block_t old_blk_addr;
> struct dnode_of_data dn;
> int err;
> @@ -50,7 +49,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
> }
>
> old_blk_addr = dn.data_blkaddr;
> - node_page = dn.node_page;
>
> if (old_blk_addr == NULL_ADDR) {
> err = reserve_new_block(&dn);
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 5975568..6891e45 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -509,13 +509,11 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct page *page,
> }
>
> if (bit_pos == NR_DENTRY_IN_BLOCK) {
> - loff_t page_offset;
> truncate_hole(dir, page->index, page->index + 1);
> clear_page_dirty_for_io(page);
> ClearPageUptodate(page);
> dec_page_count(sbi, F2FS_DIRTY_DENTS);
> inode_dec_dirty_dents(dir);
> - page_offset = page->index << PAGE_CACHE_SHIFT;
> f2fs_put_page(page, 1);
> } else {
> f2fs_put_page(page, 1);
>
>
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-02 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-02 13:11 [PATCH -next] f2fs: remove unused variable Wei Yongjun
2012-12-02 23:12 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®