* [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL
@ 2013-01-23 3:19 Su, Xuemin
2013-01-23 9:53 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Su, Xuemin @ 2013-01-23 3:19 UTC (permalink / raw)
To: airlied, dri-devel, linux-kernel; +Cc: bo.he, xuemin.su, yanmin_zhang
From: xueminsu <xuemin.su@intel.com>
Date: Tue, 22 Jan 2013 22:39:39 +0800
Subject: [PATCH] drm_crtc: check if fb_create return NULL
Some buggy driver may still return NULL in fb_create,
which leads to kernel panic.
Signed-off-by: xueminsu <xuemin.su@intel.com>
---
drivers/gpu/drm/drm_crtc.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index f2d667b..b748498 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -2172,6 +2172,13 @@ int drm_mode_addfb(struct drm_device *dev,
ret = PTR_ERR(fb);
goto out;
}
+ /* some buggy driver may return NULL here, which may cause panic */
+ if (!fb) {
+ WARN(1, "%pf should not return NULL.",
+ dev->mode_config.funcs->fb_create);
+ ret = -EINVAL;
+ goto out;
+ }
or->fb_id = fb->base.id;
list_add(&fb->filp_head, &file_priv->fbs);
--
1.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL
2013-01-23 3:19 [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL Su, Xuemin
@ 2013-01-23 9:53 ` Daniel Vetter
2013-01-24 0:27 ` Su, Xuemin
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-01-23 9:53 UTC (permalink / raw)
To: Su, Xuemin; +Cc: airlied, dri-devel, linux-kernel, yanmin_zhang, bo.he
On Wed, Jan 23, 2013 at 11:19:27AM +0800, Su, Xuemin wrote:
> From: xueminsu <xuemin.su@intel.com>
> Date: Tue, 22 Jan 2013 22:39:39 +0800
> Subject: [PATCH] drm_crtc: check if fb_create return NULL
>
> Some buggy driver may still return NULL in fb_create,
> which leads to kernel panic.
>
> Signed-off-by: xueminsu <xuemin.su@intel.com>
Imo just BUG_ON(!fb); and call it a day. Makes it pretty clear what's
expected of the drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL
2013-01-23 9:53 ` Daniel Vetter
@ 2013-01-24 0:27 ` Su, Xuemin
0 siblings, 0 replies; 3+ messages in thread
From: Su, Xuemin @ 2013-01-24 0:27 UTC (permalink / raw)
To: Daniel Vetter; +Cc: airlied, dri-devel, linux-kernel, yanmin_zhang, He, Bo
-----Original Message-----
>From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
>Sent: Wednesday, January 23, 2013 5:54 PM
>To: Su, Xuemin
>Cc: airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; yanmin_zhang@linux.intel.com; He, Bo
>Subject: Re: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL
>Imo just BUG_ON(!fb); and call it a day. Makes it pretty clear what's expected of the drivers.
>-Daniel
Thanks, I will upload PATCH V3.
Xuemin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-24 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-23 3:19 [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL Su, Xuemin
2013-01-23 9:53 ` Daniel Vetter
2013-01-24 0:27 ` Su, Xuemin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®