From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 7/9] perf util: Get rid of read_or_die() in trace-event-read.c
Date: Tue, 19 Mar 2013 21:59:01 -0400 [thread overview]
Message-ID: <1363744741.6345.4.camel@gandalf.local.home> (raw)
In-Reply-To: <87a9pyj227.fsf@sejong.aot.lge.com>
On Wed, 2013-03-20 at 10:24 +0900, Namhyung Kim wrote:
> >> @@ -61,8 +61,10 @@ static int do_read(int fd, void *buf, int size)
> >> if (repipe) {
> >> int retw = write(STDOUT_FILENO, buf, ret);
> >>
> >> - if (retw <= 0 || retw != ret)
> >> - die("repiping input file");
> >> + if (retw <= 0 || retw != ret) {
> >> + pr_debug("repiping input file");
> >
> > Again, why debug and not err?
>
> Well, there's a pr_err() at the caller of top-level trace_report() in
> case of error. So if we use pr_err() there'll be multiple error message
> for one failure and I don't think it's so helpful to normal users. If
> one really wants to know what happens inside, she will set -v to see
> this low-level debug message.
>
> Does that make sense?
>
I haven't looked at the context of all the changes as to where they are
called from. I'm fine if we have a methodology of having pr_err() at the
top level and pr_debug() within the nested code. It looked to me that
the choices were somewhat random, but then again, I was missing context
to the code.
As long as a pr_err() that gives the user enough information to know
what went wrong is displayed, I'm fine with other errors using
pr_debug().
-- Steve
next prev parent reply other threads:[~2013-03-20 1:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 8:53 [PATCHSET 0/9] perf util: Cleanup die() and its friends Namhyung Kim
2013-03-19 8:53 ` [PATCH 1/9] perf util: Let get_tracing_file() can return NULL Namhyung Kim
2013-03-19 13:54 ` Steven Rostedt
2013-03-20 0:53 ` Namhyung Kim
2013-03-19 8:53 ` [PATCH 2/9] perf util: Get rid of malloc_or_die() in trace-event-info.c Namhyung Kim
2013-03-19 8:53 ` [PATCH 3/9] perf util: Get rid of write_or_die() from trace-event-info.c Namhyung Kim
2013-03-19 14:35 ` Steven Rostedt
2013-03-19 14:49 ` Peter Zijlstra
2013-03-19 14:59 ` Steven Rostedt
2013-03-19 15:04 ` Peter Zijlstra
2013-03-20 0:57 ` Namhyung Kim
2013-03-19 8:53 ` [PATCH 4/9] perf util: Get rid of die() calls " Namhyung Kim
2013-03-19 8:53 ` [PATCH 5/9] perf util: Handle failure case in trace_report() Namhyung Kim
2013-03-19 14:47 ` Steven Rostedt
2013-03-20 1:12 ` Namhyung Kim
2013-03-20 1:54 ` Steven Rostedt
2013-03-19 8:53 ` [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c Namhyung Kim
2013-03-19 14:50 ` Steven Rostedt
2013-03-20 1:14 ` Namhyung Kim
2013-03-20 1:55 ` Steven Rostedt
2013-03-20 3:00 ` Namhyung Kim
2013-03-20 3:13 ` Steven Rostedt
2013-03-20 13:04 ` Arnaldo Carvalho de Melo
2013-03-19 8:53 ` [PATCH 7/9] perf util: Get rid of read_or_die() " Namhyung Kim
2013-03-19 14:54 ` Steven Rostedt
2013-03-20 1:24 ` Namhyung Kim
2013-03-20 1:59 ` Steven Rostedt [this message]
2013-03-19 8:53 ` [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c Namhyung Kim
2013-03-19 14:55 ` Steven Rostedt
2013-03-20 1:25 ` Namhyung Kim
2013-03-20 13:27 ` Arnaldo Carvalho de Melo
2013-03-19 8:53 ` [PATCH 9/9] perf util: Cleanup calc_data_size logic Namhyung Kim
2013-03-21 7:18 [PATCHSET 0/9] perf util: Cleanup die() and its friends (v2) Namhyung Kim
2013-03-21 7:18 ` [PATCH 7/9] perf util: Get rid of read_or_die() in trace-event-read.c Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363744741.6345.4.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®