mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	Heinz Mauelshagen <heinzm@redhat.com>,
	Joe Thornber <ejt@redhat.com>, Mike Snitzer <snitzer@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Paul Taysom <taysom@chromium.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] dm: dm-cache fails to write the cache device in writethrough mode
Date: Fri, 22 Mar 2013 20:21:56 +0000	[thread overview]
Message-ID: <1363983716.3728.42.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20130322201151.GB5357@blackbox.djwong.org>

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Fri, 2013-03-22 at 13:11 -0700, Darrick J. Wong wrote:
> The new writethrough strategy for dm-cache issues a bio to the origin device,
> remaps the bio to the cache device, and issues the bio to the cache device.
> However, the block layer modifies bi_sector and bi_size, so we need to preserve
> these or else nothing gets written to the cache (bi_size == 0).  This fixes the
> problem where someone writes a block through the cache, but a subsequent reread
> (from the cache) returns old contents.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
[...]

This is not the correct way to submit a change to stable.  See
Documentation/stable_kernel_rules.txt

Ben.

-- 
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2013-03-22 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 20:11 Darrick J. Wong
2013-03-22 20:21 ` Ben Hutchings [this message]
2013-03-22 20:50   ` Darrick J. Wong
2013-03-22 21:35     ` Mike Snitzer
2013-03-22 22:34 ` Mike Snitzer
2013-03-22 23:16   ` [dm-devel] " Darrick J. Wong
2013-03-23  3:27     ` Mike Snitzer
2013-03-23  3:48       ` [dm-devel] " Alasdair G Kergon
2013-03-23  5:15       ` Darrick J. Wong
2013-03-23 21:08         ` Mike Snitzer
2013-03-23 22:56           ` Mike Snitzer
2013-03-25 23:59             ` [PATCH v2] dm cache: fix writes to " Mike Snitzer
2013-03-23 21:13         ` [dm-devel] dm: dm-cache fails to write the " Alasdair G Kergon
2013-03-23  3:00 ` [dm-devel] [PATCH] " Alasdair G Kergon
2013-03-25 10:28 ` Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363983716.3728.42.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=darrick.wong@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=heinzm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=snitzer@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=taysom@chromium.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®