From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Heinz Mauelshagen <heinzm@redhat.com>,
Joe Thornber <ejt@redhat.com>, Mike Snitzer <snitzer@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Paul Taysom <taysom@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
stable@vger.kernel.org
Subject: [PATCH] dm: dm-cache fails to write the cache device in writethrough mode
Date: Fri, 22 Mar 2013 13:11:51 -0700 [thread overview]
Message-ID: <20130322201151.GB5357@blackbox.djwong.org> (raw)
The new writethrough strategy for dm-cache issues a bio to the origin device,
remaps the bio to the cache device, and issues the bio to the cache device.
However, the block layer modifies bi_sector and bi_size, so we need to preserve
these or else nothing gets written to the cache (bi_size == 0). This fixes the
problem where someone writes a block through the cache, but a subsequent reread
(from the cache) returns old contents.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
drivers/md/dm-cache-target.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 66120bd..0db0ad2 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -205,6 +205,8 @@ struct per_bio_data {
struct cache *cache;
dm_cblock_t cblock;
bio_end_io_t *saved_bi_end_io;
+ unsigned int bi_size;
+ sector_t bi_sector;
};
struct dm_cache_migration {
@@ -643,6 +645,8 @@ static void writethrough_endio(struct bio *bio, int err)
return;
}
+ bio->bi_sector = pb->bi_sector;
+ bio->bi_size = pb->bi_size;
remap_to_cache(pb->cache, bio, pb->cblock);
/*
@@ -667,6 +671,12 @@ static void remap_to_origin_then_cache(struct cache *cache, struct bio *bio,
pb->cache = cache;
pb->cblock = cblock;
pb->saved_bi_end_io = bio->bi_end_io;
+ /*
+ * The block layer modifies bi_size and bi_sector, so we must save
+ * them for when we re-issue the bio against the cache device.
+ */
+ pb->bi_size = bio->bi_size;
+ pb->bi_sector = bio->bi_sector;
bio->bi_end_io = writethrough_endio;
remap_to_origin_clear_discard(pb->cache, bio, oblock);
next reply other threads:[~2013-03-22 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 20:11 Darrick J. Wong [this message]
2013-03-22 20:21 ` Ben Hutchings
2013-03-22 20:50 ` Darrick J. Wong
2013-03-22 21:35 ` Mike Snitzer
2013-03-22 22:34 ` Mike Snitzer
2013-03-22 23:16 ` [dm-devel] " Darrick J. Wong
2013-03-23 3:27 ` Mike Snitzer
2013-03-23 3:48 ` [dm-devel] " Alasdair G Kergon
2013-03-23 5:15 ` Darrick J. Wong
2013-03-23 21:08 ` Mike Snitzer
2013-03-23 22:56 ` Mike Snitzer
2013-03-25 23:59 ` [PATCH v2] dm cache: fix writes to " Mike Snitzer
2013-03-23 21:13 ` [dm-devel] dm: dm-cache fails to write the " Alasdair G Kergon
2013-03-23 3:00 ` [dm-devel] [PATCH] " Alasdair G Kergon
2013-03-25 10:28 ` Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322201151.GB5357@blackbox.djwong.org \
--to=darrick.wong@oracle.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=heinzm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=rdunlap@infradead.org \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=taysom@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®