* [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines
@ 2013-03-29 14:48 Paul Bolle
2013-03-31 15:47 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2013-03-29 14:48 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Entirely untested.
1) See commit 3d066d77cf464ea1e47808f95243301fd2175a7f ("powerpc: remove
CONFIG_PPC_ISERIES from the architecture Kconfig files") and commit
ba7a4822b48fbc7afd6b567c18e316a03f46684d ("powerpc: Remove some of the
legacy iSeries specific device drivers").
drivers/block/Makefile | 1 -
drivers/cdrom/Makefile | 1 -
drivers/char/Makefile | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index a3b4023..ebb3a61 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -30,7 +30,6 @@ obj-$(CONFIG_BLK_DEV_NBD) += nbd.o
obj-$(CONFIG_BLK_DEV_CRYPTOLOOP) += cryptoloop.o
obj-$(CONFIG_VIRTIO_BLK) += virtio_blk.o
-obj-$(CONFIG_VIODASD) += viodasd.o
obj-$(CONFIG_BLK_DEV_SX8) += sx8.o
obj-$(CONFIG_BLK_DEV_HD) += hd.o
diff --git a/drivers/cdrom/Makefile b/drivers/cdrom/Makefile
index ecf85fd..8ffde4f 100644
--- a/drivers/cdrom/Makefile
+++ b/drivers/cdrom/Makefile
@@ -10,5 +10,4 @@ obj-$(CONFIG_BLK_DEV_SR) += cdrom.o
obj-$(CONFIG_PARIDE_PCD) += cdrom.o
obj-$(CONFIG_CDROM_PKTCDVD) += cdrom.o
-obj-$(CONFIG_VIOCD) += viocd.o cdrom.o
obj-$(CONFIG_GDROM) += gdrom.o cdrom.o
diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index 7ff1d0d..290fe5b 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -13,7 +13,6 @@ obj-$(CONFIG_MSM_SMD_PKT) += msm_smd_pkt.o
obj-$(CONFIG_MSPEC) += mspec.o
obj-$(CONFIG_MMTIMER) += mmtimer.o
obj-$(CONFIG_UV_MMTIMER) += uv_mmtimer.o
-obj-$(CONFIG_VIOTAPE) += viotape.o
obj-$(CONFIG_IBM_BSR) += bsr.o
obj-$(CONFIG_SGI_MBCS) += mbcs.o
obj-$(CONFIG_BFIN_OTP) += bfin-otp.o
--
1.7.11.7
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines
2013-03-29 14:48 [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines Paul Bolle
@ 2013-03-31 15:47 ` Jiri Kosina
2013-04-01 19:31 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2013-03-31 15:47 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-kernel
On Fri, 29 Mar 2013, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Entirely untested.
>
> 1) See commit 3d066d77cf464ea1e47808f95243301fd2175a7f ("powerpc: remove
> CONFIG_PPC_ISERIES from the architecture Kconfig files") and commit
> ba7a4822b48fbc7afd6b567c18e316a03f46684d ("powerpc: Remove some of the
> legacy iSeries specific device drivers").
I believe you could remove all the corresponding major number defines from
include/uapi/linux/major.h while you are at it.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines
2013-03-31 15:47 ` Jiri Kosina
@ 2013-04-01 19:31 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2013-04-01 19:31 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel
On Sun, 2013-03-31 at 17:47 +0200, Jiri Kosina wrote:
> I believe you could remove all the corresponding major number defines from
> include/uapi/linux/major.h while you are at it.
0) You seem to mean these:
$ grep VIO include/uapi/linux/major.h
#define VIODASD_MAJOR 112
#define VIOCD_MAJOR 113
#define VIOTAPE_MAJOR 230
They are indeed unused. But are they safe to be removed? I'm always very
cautious with touching magic numbers, and the like (even obsolete).
1) Anyhow, if they really can be removed, I prefer to do that in a
separate patch.
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-01 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-29 14:48 [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines Paul Bolle
2013-03-31 15:47 ` Jiri Kosina
2013-04-01 19:31 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®