* [PATCH] 9p: trace: use %*ph to dump buffer @ 2013-04-22 13:01 Andy Shevchenko 2013-05-28 8:49 ` Andy Shevchenko 0 siblings, 1 reply; 4+ messages in thread From: Andy Shevchenko @ 2013-04-22 13:01 UTC (permalink / raw) To: Ingo Molnar, Steven Rostedt, linux-kernel; +Cc: Andy Shevchenko Additionally change cast from long to unsigned long to follow specificator. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/trace/events/9p.h | 28 +++------------------------- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/include/trace/events/9p.h b/include/trace/events/9p.h index beeaed8..a066636 100644 --- a/include/trace/events/9p.h +++ b/include/trace/events/9p.h @@ -143,31 +143,9 @@ TRACE_EVENT(9p_protocol_dump, __entry->tag = pdu->tag; memcpy(__entry->line, pdu->sdata, P9_PROTO_DUMP_SZ); ), - TP_printk("clnt %lu %s(tag = %d)\n%.3x: " - "%02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n" - "%.3x: " - "%02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n", - (long)__entry->clnt, show_9p_op(__entry->type), - __entry->tag, 0, - __entry->line[0], __entry->line[1], - __entry->line[2], __entry->line[3], - __entry->line[4], __entry->line[5], - __entry->line[6], __entry->line[7], - __entry->line[8], __entry->line[9], - __entry->line[10], __entry->line[11], - __entry->line[12], __entry->line[13], - __entry->line[14], __entry->line[15], - 16, - __entry->line[16], __entry->line[17], - __entry->line[18], __entry->line[19], - __entry->line[20], __entry->line[21], - __entry->line[22], __entry->line[23], - __entry->line[24], __entry->line[25], - __entry->line[26], __entry->line[27], - __entry->line[28], __entry->line[29], - __entry->line[30], __entry->line[31]) + TP_printk("clnt %lu %s(tag = %d)\n%.3x: %16ph\n%.3x: %16ph\n", + (unsigned long)__entry->clnt, show_9p_op(__entry->type), + __entry->tag, 0, __entry->line, 16, __entry->line + 16) ); #endif /* _TRACE_9P_H */ -- 1.8.2.rc0.22.gb3600c3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 9p: trace: use %*ph to dump buffer 2013-04-22 13:01 [PATCH] 9p: trace: use %*ph to dump buffer Andy Shevchenko @ 2013-05-28 8:49 ` Andy Shevchenko 2013-05-28 18:09 ` Rob Landley 2013-05-28 18:45 ` Steven Rostedt 0 siblings, 2 replies; 4+ messages in thread From: Andy Shevchenko @ 2013-05-28 8:49 UTC (permalink / raw) To: Ingo Molnar; +Cc: Steven Rostedt, linux-kernel On Mon, 2013-04-22 at 16:01 +0300, Andy Shevchenko wrote: > Additionally change cast from long to unsigned long to follow specificator. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/trace/events/9p.h | 28 +++------------------------- > 1 file changed, 3 insertions(+), 25 deletions(-) > > diff --git a/include/trace/events/9p.h b/include/trace/events/9p.h > index beeaed8..a066636 100644 > --- a/include/trace/events/9p.h > +++ b/include/trace/events/9p.h > @@ -143,31 +143,9 @@ TRACE_EVENT(9p_protocol_dump, > __entry->tag = pdu->tag; > memcpy(__entry->line, pdu->sdata, P9_PROTO_DUMP_SZ); > ), > - TP_printk("clnt %lu %s(tag = %d)\n%.3x: " > - "%02x %02x %02x %02x %02x %02x %02x %02x " > - "%02x %02x %02x %02x %02x %02x %02x %02x\n" > - "%.3x: " > - "%02x %02x %02x %02x %02x %02x %02x %02x " > - "%02x %02x %02x %02x %02x %02x %02x %02x\n", > - (long)__entry->clnt, show_9p_op(__entry->type), > - __entry->tag, 0, > - __entry->line[0], __entry->line[1], > - __entry->line[2], __entry->line[3], > - __entry->line[4], __entry->line[5], > - __entry->line[6], __entry->line[7], > - __entry->line[8], __entry->line[9], > - __entry->line[10], __entry->line[11], > - __entry->line[12], __entry->line[13], > - __entry->line[14], __entry->line[15], > - 16, > - __entry->line[16], __entry->line[17], > - __entry->line[18], __entry->line[19], > - __entry->line[20], __entry->line[21], > - __entry->line[22], __entry->line[23], > - __entry->line[24], __entry->line[25], > - __entry->line[26], __entry->line[27], > - __entry->line[28], __entry->line[29], > - __entry->line[30], __entry->line[31]) > + TP_printk("clnt %lu %s(tag = %d)\n%.3x: %16ph\n%.3x: %16ph\n", > + (unsigned long)__entry->clnt, show_9p_op(__entry->type), > + __entry->tag, 0, __entry->line, 16, __entry->line + 16) > ); > > #endif /* _TRACE_9P_H */ Any comment on this one, anyone? -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 9p: trace: use %*ph to dump buffer 2013-05-28 8:49 ` Andy Shevchenko @ 2013-05-28 18:09 ` Rob Landley 2013-05-28 18:45 ` Steven Rostedt 1 sibling, 0 replies; 4+ messages in thread From: Rob Landley @ 2013-05-28 18:09 UTC (permalink / raw) To: Andy Shevchenko Cc: Ingo Molnar, Steven Rostedt, linux-kernel, v9fs-developer, Eric Van Hensbergen [-- Attachment #1: Type: text/plain, Size: 2504 bytes --] On 05/28/2013 03:49:52 AM, Andy Shevchenko wrote: > On Mon, 2013-04-22 at 16:01 +0300, Andy Shevchenko wrote: > > Additionally change cast from long to unsigned long to follow > specificator. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > include/trace/events/9p.h | 28 +++------------------------- > > 1 file changed, 3 insertions(+), 25 deletions(-) > > > > diff --git a/include/trace/events/9p.h b/include/trace/events/9p.h > > index beeaed8..a066636 100644 > > --- a/include/trace/events/9p.h > > +++ b/include/trace/events/9p.h > > @@ -143,31 +143,9 @@ TRACE_EVENT(9p_protocol_dump, > > __entry->tag = pdu->tag; > > memcpy(__entry->line, pdu->sdata, P9_PROTO_DUMP_SZ); > > ), > > - TP_printk("clnt %lu %s(tag = %d)\n%.3x: " > > - "%02x %02x %02x %02x %02x %02x %02x %02x " > > - "%02x %02x %02x %02x %02x %02x %02x %02x\n" > > - "%.3x: " > > - "%02x %02x %02x %02x %02x %02x %02x %02x " > > - "%02x %02x %02x %02x %02x %02x %02x %02x\n", > > - (long)__entry->clnt, show_9p_op(__entry->type), > > - __entry->tag, 0, > > - __entry->line[0], __entry->line[1], > > - __entry->line[2], __entry->line[3], > > - __entry->line[4], __entry->line[5], > > - __entry->line[6], __entry->line[7], > > - __entry->line[8], __entry->line[9], > > - __entry->line[10], __entry->line[11], > > - __entry->line[12], __entry->line[13], > > - __entry->line[14], __entry->line[15], > > - 16, > > - __entry->line[16], __entry->line[17], > > - __entry->line[18], __entry->line[19], > > - __entry->line[20], __entry->line[21], > > - __entry->line[22], __entry->line[23], > > - __entry->line[24], __entry->line[25], > > - __entry->line[26], __entry->line[27], > > - __entry->line[28], __entry->line[29], > > - __entry->line[30], __entry->line[31]) > > + TP_printk("clnt %lu %s(tag = %d)\n%.3x: %16ph\n%.3x: > %16ph\n", > > + (unsigned long)__entry->clnt, > show_9p_op(__entry->type), > > + __entry->tag, 0, __entry->line, 16, __entry->line > + 16) > > ); > > > > #endif /* _TRACE_9P_H */ > > Any comment on this one, anyone? While we're at it, here's a patch adding the rest of the 9p files to the maintainers entry, in hopes that Erich and the list get pinged on this stuff in future. Rob [-- Attachment #2: 9p.patch --] [-- Type: text/x-patch, Size: 526 bytes --] Add rest of the 9p files to the maintainers entry. MAINTAINERS | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fd3a495..386fafa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -180,6 +180,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git S: Maintained F: Documentation/filesystems/9p.txt F: fs/9p/ +F: net/9p/ +F: include/net/9p/ +F: include/uapi/linux/virtio_9p.h +F: include/trace/events/9p.h + A8293 MEDIA DRIVER M: Antti Palosaari <crope@iki.fi> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 9p: trace: use %*ph to dump buffer 2013-05-28 8:49 ` Andy Shevchenko 2013-05-28 18:09 ` Rob Landley @ 2013-05-28 18:45 ` Steven Rostedt 1 sibling, 0 replies; 4+ messages in thread From: Steven Rostedt @ 2013-05-28 18:45 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Ingo Molnar, linux-kernel On Tue, 2013-05-28 at 11:49 +0300, Andy Shevchenko wrote: > Any comment on this one, anyone? > Tracepoints are the responsibility of the maintainers that the code they reside in. But I like to be Cc'd just to make sure things are not done incorrectly. This change looks fine to me, but thanks for Cc'ing me, as the libtraceevent needs to be updated to handle this change, such that perf can parse it too. -- Steve ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-28 18:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-04-22 13:01 [PATCH] 9p: trace: use %*ph to dump buffer Andy Shevchenko 2013-05-28 8:49 ` Andy Shevchenko 2013-05-28 18:09 ` Rob Landley 2013-05-28 18:45 ` Steven Rostedt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome