mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kosaki.motohiro@gmail.com
To: linux-kernel@vger.kernel.org
Cc: "Olivier Langlois" <olivier@trillion01.com>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"David Miller" <davem@davemloft.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Keerthy <j-keerthy@ti.com>, "Benoît Cousson" <b-cousson@ti.com>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Tony Lindgren" <tony@atomide.com>
Subject: [PATCH 03/10] ARM: OMAP4: hwmod data: make 'ocp2scp_usb_phy_phy_48m" as the main clock
Date: Mon, 29 Apr 2013 23:17:11 -0400	[thread overview]
Message-ID: <1367291838-5490-4-git-send-email-kosaki.motohiro@gmail.com> (raw)
In-Reply-To: <1367291838-5490-1-git-send-email-kosaki.motohiro@gmail.com>

From: Kishon Vijay Abraham I <kishon@ti.com>

Commit 92702df3570e ("ARM: OMAP4: PM: fix PM regression introduced by recent
clock cleanup") makes the 'ocp2scp_usb_phy_phy_48m' as optional
functional clock causing regression in MUSB. But this 48MHz clock is a
mandatory clock for usb phy attached to ocp2scp and hence made as the main
clock for ocp2scp.

Cc: Keerthy <j-keerthy@ti.com>
Cc: Benoît Cousson <b-cousson@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
[paul@pwsan.com: add comment to the hwmod data to try to prevent any
 future mistakes here]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   18 +++++++++++-------
 1 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 9e05765..eaba9dc 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2714,16 +2714,22 @@ static struct omap_ocp2scp_dev ocp2scp_dev_attr[] = {
 	{ }
 };
 
-static struct omap_hwmod_opt_clk ocp2scp_usb_phy_opt_clks[] = {
-	{ .role = "48mhz", .clk = "ocp2scp_usb_phy_phy_48m" },
-};
-
 /* ocp2scp_usb_phy */
 static struct omap_hwmod omap44xx_ocp2scp_usb_phy_hwmod = {
 	.name		= "ocp2scp_usb_phy",
 	.class		= &omap44xx_ocp2scp_hwmod_class,
 	.clkdm_name	= "l3_init_clkdm",
-	.main_clk	= "func_48m_fclk",
+	/*
+	 * ocp2scp_usb_phy_phy_48m is provided by the OMAP4 PRCM IP
+	 * block as an "optional clock," and normally should never be
+	 * specified as the main_clk for an OMAP IP block.  However it
+	 * turns out that this clock is actually the main clock for
+	 * the ocp2scp_usb_phy IP block:
+	 * http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/119943.html
+	 * So listing ocp2scp_usb_phy_phy_48m as a main_clk here seems
+	 * to be the best workaround.
+	 */
+	.main_clk	= "ocp2scp_usb_phy_phy_48m",
 	.prcm = {
 		.omap4 = {
 			.clkctrl_offs = OMAP4_CM_L3INIT_USBPHYOCP2SCP_CLKCTRL_OFFSET,
@@ -2732,8 +2738,6 @@ static struct omap_hwmod omap44xx_ocp2scp_usb_phy_hwmod = {
 		},
 	},
 	.dev_attr	= ocp2scp_dev_attr,
-	.opt_clks	= ocp2scp_usb_phy_opt_clks,
-	.opt_clks_cnt	= ARRAY_SIZE(ocp2scp_usb_phy_opt_clks),
 };
 
 /*
-- 
1.7.1


  parent reply	other threads:[~2013-04-30  3:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  3:17 [PATCH v3 0/7] posix-cpu-timers fixlet kosaki.motohiro
2013-04-30  3:17 ` [PATCH 01/10] events: Protect access via task_subsys_state_check() kosaki.motohiro
2013-04-30  3:17 ` [PATCH 02/10] vm: add no-mmu vm_iomap_memory() stub kosaki.motohiro
2013-04-30  3:17 ` kosaki.motohiro [this message]
2013-04-30  3:17 ` [PATCH 04/10] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting kosaki.motohiro
2013-04-30  3:38   ` KOSAKI Motohiro
2013-04-30  3:17 ` [PATCH 05/10] posix-cpu-timers: fix acounting delta_exec twice kosaki.motohiro
2013-04-30  3:17 ` [PATCH 06/10] posix-cpu-timers: fix wrong timer initialization kosaki.motohiro
2013-04-30 13:34   ` Olivier Langlois
2013-04-30  3:17 ` [PATCH 07/10] posix-cpu-timers: timer functions must use timer time instead of clock time kosaki.motohiro
2013-04-30  3:17 ` [PATCH 08/10] posix-cpu-timers: check_thread_timers() uses task_sched_runtime() kosaki.motohiro
2013-04-30  3:17 ` [PATCH 09/10] sched: task_sched_runtime introduce micro optimization kosaki.motohiro
2013-05-01 11:00   ` Peter Zijlstra
2013-05-01 11:50     ` Paul Turner
2013-05-01 18:55       ` KOSAKI Motohiro
2013-05-01 18:42     ` KOSAKI Motohiro
2013-04-30  3:17 ` [PATCH 10/10] posix-cpu-timers: cleanup cpu_{clock,timer}_sample{,_group} kosaki.motohiro
2013-05-01 11:01 ` [PATCH v3 0/7] posix-cpu-timers fixlet Peter Zijlstra
2013-05-01 18:45   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367291838-5490-4-git-send-email-kosaki.motohiro@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=b-cousson@ti.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=j-keerthy@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=olivier@trillion01.com \
    --cc=paul@pwsan.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®