mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kosaki.motohiro@gmail.com
To: linux-kernel@vger.kernel.org
Cc: Olivier Langlois <olivier@trillion01.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	David Miller <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: [PATCH 04/10] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting
Date: Mon, 29 Apr 2013 23:17:12 -0400	[thread overview]
Message-ID: <1367291838-5490-5-git-send-email-kosaki.motohiro@gmail.com> (raw)
In-Reply-To: <1367291838-5490-1-git-send-email-kosaki.motohiro@gmail.com>

From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

When tsk->signal->cputimer->running is 1, signal->cputimer and
tsk->sum_sched_runtime increase the same pace. update_curr() increase
both account.

However, there is one exeception. When thread exiting, __exit_signal()
turns over task's sum_shced_runtime to sig->sum_sched_runtime. but it
doesn't stop signal->cputimer accounting.

This inconsistency makes too early POSIX timer wakeup. Fix it.

Signed-off-by: Olivier Langlois <olivier@trillion01.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 kernel/sched/stats.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
index 2ef90a5..5a0cfc4 100644
--- a/kernel/sched/stats.h
+++ b/kernel/sched/stats.h
@@ -225,6 +225,13 @@ static inline void account_group_exec_runtime(struct task_struct *tsk,
 	if (!cputimer->running)
 		return;
 
+	/*
+	 * After turning over se.sum_exec_runtime to sig->sum_sched_runtime
+	 * in __exit_signal(), we must not account exec_runtime for consistency.
+	 */
+	if (unlikely(!tsk->sighand))
+		return;
+
 	raw_spin_lock(&cputimer->lock);
 	cputimer->cputime.sum_exec_runtime += ns;
 	raw_spin_unlock(&cputimer->lock);
-- 
1.7.1


  parent reply	other threads:[~2013-04-30  3:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  3:17 [PATCH v3 0/7] posix-cpu-timers fixlet kosaki.motohiro
2013-04-30  3:17 ` [PATCH 01/10] events: Protect access via task_subsys_state_check() kosaki.motohiro
2013-04-30  3:17 ` [PATCH 02/10] vm: add no-mmu vm_iomap_memory() stub kosaki.motohiro
2013-04-30  3:17 ` [PATCH 03/10] ARM: OMAP4: hwmod data: make 'ocp2scp_usb_phy_phy_48m" as the main clock kosaki.motohiro
2013-04-30  3:17 ` kosaki.motohiro [this message]
2013-04-30  3:38   ` [PATCH 04/10] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting KOSAKI Motohiro
2013-04-30  3:17 ` [PATCH 05/10] posix-cpu-timers: fix acounting delta_exec twice kosaki.motohiro
2013-04-30  3:17 ` [PATCH 06/10] posix-cpu-timers: fix wrong timer initialization kosaki.motohiro
2013-04-30 13:34   ` Olivier Langlois
2013-04-30  3:17 ` [PATCH 07/10] posix-cpu-timers: timer functions must use timer time instead of clock time kosaki.motohiro
2013-04-30  3:17 ` [PATCH 08/10] posix-cpu-timers: check_thread_timers() uses task_sched_runtime() kosaki.motohiro
2013-04-30  3:17 ` [PATCH 09/10] sched: task_sched_runtime introduce micro optimization kosaki.motohiro
2013-05-01 11:00   ` Peter Zijlstra
2013-05-01 11:50     ` Paul Turner
2013-05-01 18:55       ` KOSAKI Motohiro
2013-05-01 18:42     ` KOSAKI Motohiro
2013-04-30  3:17 ` [PATCH 10/10] posix-cpu-timers: cleanup cpu_{clock,timer}_sample{,_group} kosaki.motohiro
2013-05-01 11:01 ` [PATCH v3 0/7] posix-cpu-timers fixlet Peter Zijlstra
2013-05-01 18:45   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367291838-5490-5-git-send-email-kosaki.motohiro@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=olivier@trillion01.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®