mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Xie <chao.xie@marvell.com>
To: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>,
	<yizhang@marvell.com>
Cc: Chao Xie <chao.xie@marvell.com>
Subject: [PATCH V2 1/9] mfd: 88pm800: fix NULL pointer error
Date: Fri, 14 Jun 2013 01:21:45 -0400	[thread overview]
Message-ID: <1371187313-5776-2-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1371187313-5776-1-git-send-email-chao.xie@marvell.com>

From: Yi Zhang <yizhang@marvell.com>

move "device_800_init" to fix NULL pointer error when
calling "device_gpadc_init"

for "device_gpadc_init" needs "subchip->regmap_gpadc"
to set registers via regmap interface

Signed-off-by: Yi Zhang <yizhang@marvell.com>
Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
 drivers/mfd/88pm800.c |   18 ++++++++++--------
 1 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 582bda5..b2f9f0f 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -528,24 +528,26 @@ static int pm800_probe(struct i2c_client *client,
 	subchip->gpadc_page_addr = pdata->gpadc_page_addr;
 	chip->subchip = subchip;
 
-	ret = device_800_init(chip, pdata);
-	if (ret) {
-		dev_err(chip->dev, "%s id 0x%x failed!\n", __func__, chip->id);
-		goto err_subchip_alloc;
-	}
-
 	ret = pm800_pages_init(chip);
 	if (ret) {
 		dev_err(&client->dev, "pm800_pages_init failed!\n");
 		goto err_page_init;
 	}
 
+	ret = device_800_init(chip, pdata);
+	if (ret) {
+		dev_err(chip->dev, "%s id 0x%x failed!\n", __func__, chip->id);
+		goto err_device_init;
+	}
+
 	if (pdata->plat_config)
 		pdata->plat_config(chip, pdata);
 
+	return 0;
+
+err_device_init:
+	pm800_pages_exit(chip);
 err_page_init:
-	mfd_remove_devices(chip->dev);
-	device_irq_exit_800(chip);
 err_subchip_alloc:
 	pm80x_deinit();
 out_init:
-- 
1.7.4.1


  reply	other threads:[~2013-06-14  5:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  5:21 [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Chao Xie
2013-06-14  5:21 ` Chao Xie [this message]
2013-06-14  5:21 ` [PATCH V2 2/9] mfd: 88pm80x: fix driver name for 88pm800 and 88pm805 Chao Xie
2013-06-14  5:21 ` [PATCH V2 3/9] mfd: 88pm800: fix for mask_invert Chao Xie
2013-06-14  5:21 ` [PATCH V2 4/9] mfd: 88pm800/88pm805: remove "IRQF_TRIGGER_FALLING" flag Chao Xie
2013-06-14  5:21 ` [PATCH V2 5/9] mfd: 88pm800: remove the power and gpadc page addr from platform data Chao Xie
2013-06-14  5:21 ` [PATCH V2 6/9] mfd: 88pm800: fixes error handling for sub pages probe/remove Chao Xie
2013-06-14  5:21 ` [PATCH V2 7/9] mfd: 88pm80x: Changes chip id definition and detection Chao Xie
2013-06-14  5:21 ` [PATCH V2 8/9] mfd: 88pm800: enhance sub devices initialization Chao Xie
2013-06-14  5:21 ` [PATCH V2 9/9] mfd: 88pm800: add regulator sub device Chao Xie
2013-06-17 23:07 ` [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371187313-5776-2-git-send-email-chao.xie@marvell.com \
    --to=chao.xie@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=yizhang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®