From: Chao Xie <chao.xie@marvell.com>
To: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>,
<yizhang@marvell.com>
Cc: Chao Xie <chao.xie@marvell.com>
Subject: [PATCH V2 5/9] mfd: 88pm800: remove the power and gpadc page addr from platform data
Date: Fri, 14 Jun 2013 01:21:49 -0400 [thread overview]
Message-ID: <1371187313-5776-6-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1371187313-5776-1-git-send-email-chao.xie@marvell.com>
88pm800 has two addtional pages - power and gpadc.
The address of the pages depends on the address of 88pm800.
So do not need pass the address of the power and gpadc in
platform data.
Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
drivers/mfd/88pm800.c | 5 +++--
include/linux/mfd/88pm80x.h | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index d2951d7..6b607ad 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -525,8 +525,9 @@ static int pm800_probe(struct i2c_client *client,
goto err_subchip_alloc;
}
- subchip->power_page_addr = pdata->power_page_addr;
- subchip->gpadc_page_addr = pdata->gpadc_page_addr;
+ /* pm800 has 2 addtional pages to support power and gpadc. */
+ subchip->power_page_addr = client->addr + 1;
+ subchip->gpadc_page_addr = client->addr + 2;
chip->subchip = subchip;
ret = pm800_pages_init(chip);
diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index e94537b..023e639 100644
--- a/include/linux/mfd/88pm80x.h
+++ b/include/linux/mfd/88pm80x.h
@@ -309,8 +309,6 @@ struct pm80x_chip {
struct pm80x_platform_data {
struct pm80x_rtc_pdata *rtc;
- unsigned short power_page_addr; /* power page I2C address */
- unsigned short gpadc_page_addr; /* gpadc page I2C address */
int irq_mode; /* Clear interrupt by read/write(0/1) */
int batt_det; /* enable/disable */
int (*plat_config)(struct pm80x_chip *chip,
--
1.7.4.1
next prev parent reply other threads:[~2013-06-14 5:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 5:21 [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Chao Xie
2013-06-14 5:21 ` [PATCH V2 1/9] mfd: 88pm800: fix NULL pointer error Chao Xie
2013-06-14 5:21 ` [PATCH V2 2/9] mfd: 88pm80x: fix driver name for 88pm800 and 88pm805 Chao Xie
2013-06-14 5:21 ` [PATCH V2 3/9] mfd: 88pm800: fix for mask_invert Chao Xie
2013-06-14 5:21 ` [PATCH V2 4/9] mfd: 88pm800/88pm805: remove "IRQF_TRIGGER_FALLING" flag Chao Xie
2013-06-14 5:21 ` Chao Xie [this message]
2013-06-14 5:21 ` [PATCH V2 6/9] mfd: 88pm800: fixes error handling for sub pages probe/remove Chao Xie
2013-06-14 5:21 ` [PATCH V2 7/9] mfd: 88pm80x: Changes chip id definition and detection Chao Xie
2013-06-14 5:21 ` [PATCH V2 8/9] mfd: 88pm800: enhance sub devices initialization Chao Xie
2013-06-14 5:21 ` [PATCH V2 9/9] mfd: 88pm800: add regulator sub device Chao Xie
2013-06-17 23:07 ` [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371187313-5776-6-git-send-email-chao.xie@marvell.com \
--to=chao.xie@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®