From: Chao Xie <chao.xie@marvell.com>
To: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>,
<yizhang@marvell.com>
Cc: Chao Xie <chao.xie@marvell.com>
Subject: [PATCH V2 4/9] mfd: 88pm800/88pm805: remove "IRQF_TRIGGER_FALLING" flag
Date: Fri, 14 Jun 2013 01:21:48 -0400 [thread overview]
Message-ID: <1371187313-5776-5-git-send-email-chao.xie@marvell.com> (raw)
In-Reply-To: <1371187313-5776-1-git-send-email-chao.xie@marvell.com>
From: Yi Zhang <yizhang@marvell.com>
88pm800/88pm805 interrupt is asserted low if the events happened.
So remove IRQF_TRIGGER_FALLING for irq request.
How the interrupt is connected to SOC chip depends on the board design.
So do not set IRQF_TRIGGER flags.
Signed-off-by: Yi Zhang <yizhang@marvell.com>
Signed-off-by: Chao Xie <chao.xie@marvell.com>
---
drivers/mfd/88pm800.c | 2 +-
drivers/mfd/88pm805.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index cca63f2..d2951d7 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -318,7 +318,7 @@ out:
static int device_irq_init_800(struct pm80x_chip *chip)
{
struct regmap *map = chip->regmap;
- unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+ unsigned long flags = IRQF_ONESHOT;
int data, mask, ret = -EINVAL;
if (!map || !chip->irq) {
diff --git a/drivers/mfd/88pm805.c b/drivers/mfd/88pm805.c
index d32b544..0e82c2a 100644
--- a/drivers/mfd/88pm805.c
+++ b/drivers/mfd/88pm805.c
@@ -138,7 +138,7 @@ static struct regmap_irq pm805_irqs[] = {
static int device_irq_init_805(struct pm80x_chip *chip)
{
struct regmap *map = chip->regmap;
- unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
+ unsigned long flags = IRQF_ONESHOT;
int data, mask, ret = -EINVAL;
if (!map || !chip->irq) {
--
1.7.4.1
next prev parent reply other threads:[~2013-06-14 5:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 5:21 [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Chao Xie
2013-06-14 5:21 ` [PATCH V2 1/9] mfd: 88pm800: fix NULL pointer error Chao Xie
2013-06-14 5:21 ` [PATCH V2 2/9] mfd: 88pm80x: fix driver name for 88pm800 and 88pm805 Chao Xie
2013-06-14 5:21 ` [PATCH V2 3/9] mfd: 88pm800: fix for mask_invert Chao Xie
2013-06-14 5:21 ` Chao Xie [this message]
2013-06-14 5:21 ` [PATCH V2 5/9] mfd: 88pm800: remove the power and gpadc page addr from platform data Chao Xie
2013-06-14 5:21 ` [PATCH V2 6/9] mfd: 88pm800: fixes error handling for sub pages probe/remove Chao Xie
2013-06-14 5:21 ` [PATCH V2 7/9] mfd: 88pm80x: Changes chip id definition and detection Chao Xie
2013-06-14 5:21 ` [PATCH V2 8/9] mfd: 88pm800: enhance sub devices initialization Chao Xie
2013-06-14 5:21 ` [PATCH V2 9/9] mfd: 88pm800: add regulator sub device Chao Xie
2013-06-17 23:07 ` [PATCH V2 0/9] mfd: 88pm80x: bug fixes and enhancement Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371187313-5776-5-git-send-email-chao.xie@marvell.com \
--to=chao.xie@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®