* [PATCH 0/4] Minor selftests cleanups
@ 2013-06-30 12:53 Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 1/4] selftests: add .gitignore for vm Ramkumar Ramachandra
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-30 12:53 UTC (permalink / raw)
To: LKML; +Cc: Dave Young
Just ran a few of them. Unsure about [4/4] because of aabccae6 and
a58130d.
Thanks.
Ramkumar Ramachandra (4):
selftests: add .gitignore for vm
selftests: fix clean target in kcmp Makefile
selftests: add .gitignore for kcmp
selftests: get {cpu,memory}-hotplug tests to run
tools/testing/selftests/cpu-hotplug/on-off-test.sh | 0
tools/testing/selftests/kcmp/.gitignore | 2 ++
tools/testing/selftests/kcmp/Makefile | 3 +--
tools/testing/selftests/memory-hotplug/on-off-test.sh | 0
tools/testing/selftests/vm/.gitignore | 4 ++++
5 files changed, 7 insertions(+), 2 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/cpu-hotplug/on-off-test.sh
create mode 100644 tools/testing/selftests/kcmp/.gitignore
mode change 100644 => 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
create mode 100644 tools/testing/selftests/vm/.gitignore
--
1.8.3.1.643.gebeea52.dirty
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/4] selftests: add .gitignore for vm
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
@ 2013-06-30 12:53 ` Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 2/4] selftests: fix clean target in kcmp Makefile Ramkumar Ramachandra
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-30 12:53 UTC (permalink / raw)
To: LKML; +Cc: Dave Young
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/testing/selftests/vm/.gitignore | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 tools/testing/selftests/vm/.gitignore
diff --git a/tools/testing/selftests/vm/.gitignore b/tools/testing/selftests/vm/.gitignore
new file mode 100644
index 0000000..ff1bb16
--- /dev/null
+++ b/tools/testing/selftests/vm/.gitignore
@@ -0,0 +1,4 @@
+hugepage-mmap
+hugepage-shm
+map_hugetlb
+thuge-gen
--
1.8.3.1.643.gebeea52.dirty
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] selftests: fix clean target in kcmp Makefile
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 1/4] selftests: add .gitignore for vm Ramkumar Ramachandra
@ 2013-06-30 12:53 ` Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 3/4] selftests: add .gitignore for kcmp Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run Ramkumar Ramachandra
3 siblings, 0 replies; 6+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-30 12:53 UTC (permalink / raw)
To: LKML; +Cc: Dave Young
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/testing/selftests/kcmp/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
index 56eb552..d7d6bbe 100644
--- a/tools/testing/selftests/kcmp/Makefile
+++ b/tools/testing/selftests/kcmp/Makefile
@@ -25,5 +25,4 @@ run_tests: all
@./kcmp_test || echo "kcmp_test: [FAIL]"
clean:
- rm -fr ./run_test
- rm -fr ./test-file
+ $(RM) kcmp_test kcmp-test-file
--
1.8.3.1.643.gebeea52.dirty
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] selftests: add .gitignore for kcmp
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 1/4] selftests: add .gitignore for vm Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 2/4] selftests: fix clean target in kcmp Makefile Ramkumar Ramachandra
@ 2013-06-30 12:53 ` Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run Ramkumar Ramachandra
3 siblings, 0 replies; 6+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-30 12:53 UTC (permalink / raw)
To: LKML; +Cc: Dave Young
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/testing/selftests/kcmp/.gitignore | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 tools/testing/selftests/kcmp/.gitignore
diff --git a/tools/testing/selftests/kcmp/.gitignore b/tools/testing/selftests/kcmp/.gitignore
new file mode 100644
index 0000000..5a9b373
--- /dev/null
+++ b/tools/testing/selftests/kcmp/.gitignore
@@ -0,0 +1,2 @@
+kcmp_test
+kcmp-test-file
--
1.8.3.1.643.gebeea52.dirty
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
` (2 preceding siblings ...)
2013-06-30 12:53 ` [PATCH 3/4] selftests: add .gitignore for kcmp Ramkumar Ramachandra
@ 2013-06-30 12:53 ` Ramkumar Ramachandra
2013-07-01 20:45 ` Andrew Morton
3 siblings, 1 reply; 6+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-30 12:53 UTC (permalink / raw)
To: LKML; +Cc: Dave Young
The cpu-hotplug and memory-hotplug tests don't run:
$ sudo make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests
/bin/sh: ./on-off-test.sh: Permission denied
$ sudo make -C tools/testing/selftests TARGETS=memory-hotplug run_tests
/bin/sh: ./on-off-test.sh: Permission denied
Flip the executable bit fixing this.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/testing/selftests/cpu-hotplug/on-off-test.sh | 0
tools/testing/selftests/memory-hotplug/on-off-test.sh | 0
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/cpu-hotplug/on-off-test.sh
mode change 100644 => 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
diff --git a/tools/testing/selftests/cpu-hotplug/on-off-test.sh b/tools/testing/selftests/cpu-hotplug/on-off-test.sh
old mode 100644
new mode 100755
diff --git a/tools/testing/selftests/memory-hotplug/on-off-test.sh b/tools/testing/selftests/memory-hotplug/on-off-test.sh
old mode 100644
new mode 100755
--
1.8.3.1.643.gebeea52.dirty
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run
2013-06-30 12:53 ` [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run Ramkumar Ramachandra
@ 2013-07-01 20:45 ` Andrew Morton
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2013-07-01 20:45 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: LKML, Dave Young
On Sun, 30 Jun 2013 18:23:11 +0530 Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> The cpu-hotplug and memory-hotplug tests don't run:
>
> $ sudo make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests
> /bin/sh: ./on-off-test.sh: Permission denied
>
> $ sudo make -C tools/testing/selftests TARGETS=memory-hotplug run_tests
> /bin/sh: ./on-off-test.sh: Permission denied
>
> Flip the executable bit fixing this.
>
> ...
>
> 2 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/cpu-hotplug/on-off-test.sh
> mode change 100644 => 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
>
> diff --git a/tools/testing/selftests/cpu-hotplug/on-off-test.sh b/tools/testing/selftests/cpu-hotplug/on-off-test.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/memory-hotplug/on-off-test.sh b/tools/testing/selftests/memory-hotplug/on-off-test.sh
> old mode 100644
> new mode 100755
That won't work. The x bit will too easily get lost again - for
example, patch(1) will rub it out.
This:
--- a/tools/testing/selftests/cpu-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts
+++ a/tools/testing/selftests/cpu-hotplug/Makefile
@@ -1,6 +1,6 @@
all:
run_tests:
- @./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]"
+ @/bin/sh ./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]"
clean:
--- a/tools/testing/selftests/memory-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts
+++ a/tools/testing/selftests/memory-hotplug/Makefile
@@ -1,6 +1,6 @@
all:
run_tests:
- @./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
+ @/bin/sh ./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
clean:
_
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-01 20:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 1/4] selftests: add .gitignore for vm Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 2/4] selftests: fix clean target in kcmp Makefile Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 3/4] selftests: add .gitignore for kcmp Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run Ramkumar Ramachandra
2013-07-01 20:45 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®