* [PATCH] staging: dwc2: fix value used in dwc2_set_all_params
@ 2013-07-11 12:24 Julien Delacou
2013-07-11 15:43 ` Matthijs Kooijman
0 siblings, 1 reply; 2+ messages in thread
From: Julien Delacou @ 2013-07-11 12:24 UTC (permalink / raw)
To: Paul Zimmerman, Greg Kroah-Hartman, Grant Likely
Cc: linux-kernel, linux-usb, devel, Julien Delacou
From: Julien Delacou <julien.delacou@stericsson.com>
This fix uses 'value' parameter as it should be instead
of hardcoded -1.
Signed-off-by: Julien Delacou <julien.delacou@stericsson.com>
Acked-by: Paul Zimmerman <paulz@synopys.com>
---
drivers/staging/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 2ed54b1..ca38aaa 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
int i;
for (i = 0; i < size; i++)
- p[i] = -1;
+ p[i] = value;
}
EXPORT_SYMBOL_GPL(dwc2_set_all_params);
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params
2013-07-11 12:24 [PATCH] staging: dwc2: fix value used in dwc2_set_all_params Julien Delacou
@ 2013-07-11 15:43 ` Matthijs Kooijman
0 siblings, 0 replies; 2+ messages in thread
From: Matthijs Kooijman @ 2013-07-11 15:43 UTC (permalink / raw)
To: Julien Delacou
Cc: Paul Zimmerman, Greg Kroah-Hartman, Grant Likely, linux-kernel,
linux-usb, devel, Julien Delacou
On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
> From: Julien Delacou <julien.delacou@stericsson.com>
>
> This fix uses 'value' parameter as it should be instead
> of hardcoded -1.
Woops!
> Signed-off-by: Julien Delacou <julien.delacou@stericsson.com>
> Acked-by: Paul Zimmerman <paulz@synopys.com>
Reviewed-by: Matthijs Kooijman <matthijs@stdin.nl>
> ---
> drivers/staging/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index 2ed54b1..ca38aaa 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
> int i;
>
> for (i = 0; i < size; i++)
> - p[i] = -1;
> + p[i] = value;
> }
> EXPORT_SYMBOL_GPL(dwc2_set_all_params);
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-11 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-11 12:24 [PATCH] staging: dwc2: fix value used in dwc2_set_all_params Julien Delacou
2013-07-11 15:43 ` Matthijs Kooijman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®