mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kaluza <jkaluza@redhat.com>
To: davem@davemloft.net
Cc: LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, eparis@redhat.com, rgb@redhat.com,
	tj@kernel.org, lizefan@huawei.com,
	containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	viro@zeniv.linux.org.uk, Jan Kaluza <jkaluza@redhat.com>
Subject: [PATCH v3 0/3] Send audit/procinfo/cgroup data in socket-level control message
Date: Wed,  4 Sep 2013 08:14:18 +0200	[thread overview]
Message-ID: <1378275261-4553-1-git-send-email-jkaluza@redhat.com> (raw)
In-Reply-To: <1377614400-27122-1-git-send-email-jkaluza@redhat.com>

Hi,

this patchset against net-next (applies also to linux-next) adds 3 new types
of "Socket"-level control message (SCM_AUDIT, SCM_PROCINFO and SCM_CGROUP).

Server-like processes in many cases need credentials and other
metadata of the peer, to decide if the calling process is allowed to
request a specific action, or the server just wants to log away this
type of information for auditing tasks.

The current practice to retrieve such process metadata is to look that
information up in procfs with the $PID received over SCM_CREDENTIALS.
This is sufficient for long-running tasks, but introduces a race which
cannot be worked around for short-living processes; the calling
process and all the information in /proc/$PID/ is gone before the
receiver of the socket message can look it up.

Changes introduced in this patchset can also increase performance
of such server-like processes, because current way of opening and
parsing /proc/$PID/* files is much more expensive than receiving these
metadata using SCM.

Changes in v3:
- Better description of patches (Thanks to Kay Sievers)

Changes in v2:
- use PATH_MAX instead of PAGE_SIZE in SCM_CGROUP patch
- describe each patch individually

Jan Kaluza (3):
  Send loginuid and sessionid in SCM_AUDIT
  Send comm and cmdline in SCM_PROCINFO
  Send cgroup_path in SCM_CGROUP

 include/linux/socket.h |  9 ++++++
 include/net/af_unix.h  | 10 ++++++
 include/net/scm.h      | 67 ++++++++++++++++++++++++++++++++++++++--
 net/core/scm.c         | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++
 net/unix/af_unix.c     | 70 ++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 237 insertions(+), 2 deletions(-)

-- 
1.8.3.1


  parent reply	other threads:[~2013-09-04  6:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 14:39 [PATCH " Jan Kaluza
2013-08-27 14:39 ` [PATCH 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-08-27 14:39 ` [PATCH 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-09-09  6:52   ` Eric W. Biederman
2013-08-27 14:40 ` [PATCH 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-08-28 14:00   ` Tejun Heo
2013-08-29 14:13 ` [PATCH v2 0/3] Send audit/procinfo/cgroup data in socket-level control message Jan Kaluza
2013-08-29 14:13   ` [PATCH v2 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-08-29 14:13   ` [PATCH v2 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-08-29 14:13   ` [PATCH v2 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-09-02 17:17     ` Kay Sievers
2013-09-04  6:14 ` Jan Kaluza [this message]
2013-09-04  6:14   ` [PATCH v3 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-09-04  7:22     ` Eric W. Biederman
2013-09-04  9:07       ` Jan Kaluža
2013-09-04  6:14   ` [PATCH v3 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-09-04  6:14   ` [PATCH v3 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-09-04  7:42   ` [PATCH v3 0/3] Send audit/procinfo/cgroup data in socket-level control message Eric W. Biederman
2013-09-04 14:45     ` Tejun Heo
2013-09-04 14:58     ` Richard Guy Briggs
2013-09-04 15:04       ` Jan Kaluža
2013-09-04 15:20       ` Richard Guy Briggs
2013-09-04 15:30         ` Eric Dumazet
2013-09-04 15:40           ` Jan Kaluža
2014-01-13  8:01 ` [PATCH v4 " Jan Kaluza
2014-01-13  8:01   ` [PATCH v4 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2014-01-15  4:02     ` Richard Guy Briggs
2014-01-13  8:01   ` [PATCH v4 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2014-01-15  4:03     ` Richard Guy Briggs
2014-01-13  8:01   ` [PATCH v4 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2014-01-13 16:52     ` Tejun Heo
2014-01-13 16:55   ` [PATCH v4 0/3] Send audit/procinfo/cgroup data in socket-level control message Tejun Heo
2014-01-13 19:44   ` Casey Schaufler
2014-01-14  8:25     ` Jan Kaluža
2014-01-15 20:17   ` David Miller
2014-01-15 23:21     ` Eric Paris
2014-01-15 23:23       ` Tejun Heo
2014-01-16  9:29         ` Jan Kaluža
2014-01-23 19:31           ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378275261-4553-1-git-send-email-jkaluza@redhat.com \
    --to=jkaluza@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=rgb@redhat.com \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®