* [PATCH] mei: Don't dev_err() on suspend
@ 2013-09-10 15:54 Adam Jackson
2013-09-10 16:06 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Adam Jackson @ 2013-09-10 15:54 UTC (permalink / raw)
To: linux-kernel; +Cc: tomas.winkler
Suspend isn't an error condition, and I'm sick of seeing this (and only
this) on the console when I suspend with quiet boot enabled.
Signed-off-by: Adam Jackson <ajax@redhat.com>
---
drivers/misc/mei/pci-me.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 1b3844e..c718f1d 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;
- dev_err(&pdev->dev, "suspend\n");
+ dev_info(&pdev->dev, "suspend\n");
mei_stop(dev);
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mei: Don't dev_err() on suspend
2013-09-10 15:54 [PATCH] mei: Don't dev_err() on suspend Adam Jackson
@ 2013-09-10 16:06 ` Joe Perches
2013-09-10 16:37 ` Winkler, Tomas
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2013-09-10 16:06 UTC (permalink / raw)
To: Adam Jackson; +Cc: linux-kernel, tomas.winkler
On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> Suspend isn't an error condition, and I'm sick of seeing this (and only
> this) on the console when I suspend with quiet boot enabled.
[]
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
[]
> @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> if (!dev)
> return -ENODEV;
>
> - dev_err(&pdev->dev, "suspend\n");
> + dev_info(&pdev->dev, "suspend\n");
dev_dbg instead?
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] mei: Don't dev_err() on suspend
2013-09-10 16:06 ` Joe Perches
@ 2013-09-10 16:37 ` Winkler, Tomas
2013-09-10 16:47 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Winkler, Tomas @ 2013-09-10 16:37 UTC (permalink / raw)
To: Joe Perches, Adam Jackson; +Cc: linux-kernel
I
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, September 10, 2013 19:06
> To: Adam Jackson
> Cc: linux-kernel@vger.kernel.org; Winkler, Tomas
> Subject: Re: [PATCH] mei: Don't dev_err() on suspend
>
> On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> > Suspend isn't an error condition, and I'm sick of seeing this (and only
> > this) on the console when I suspend with quiet boot enabled.
> []
> > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> []
> > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> > if (!dev)
> > return -ENODEV;
> >
> > - dev_err(&pdev->dev, "suspend\n");
> > + dev_info(&pdev->dev, "suspend\n");
>
> dev_dbg instead?
Yes, but I believe we fixed that long ago were do you see this?
Thanks
Tomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mei: Don't dev_err() on suspend
2013-09-10 16:37 ` Winkler, Tomas
@ 2013-09-10 16:47 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2013-09-10 16:47 UTC (permalink / raw)
To: Winkler, Tomas; +Cc: Adam Jackson, linux-kernel
On Tue, 2013-09-10 at 16:37 +0000, Winkler, Tomas wrote:
> From: Joe Perches [mailto:joe@perches.com]
> > On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> > > Suspend isn't an error condition, and I'm sick of seeing this (and only
> > > this) on the console when I suspend with quiet boot enabled.
> > []
> > > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> > []
> > > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> > > if (!dev)
> > > return -ENODEV;
> > >
> > > - dev_err(&pdev->dev, "suspend\n");
> > > + dev_info(&pdev->dev, "suspend\n");
> >
> > dev_dbg instead?
>
> Yes, but I believe we fixed that long ago were do you see this?
drivers/misc/mei/pci-me.c of both linus and -next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-10 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-10 15:54 [PATCH] mei: Don't dev_err() on suspend Adam Jackson
2013-09-10 16:06 ` Joe Perches
2013-09-10 16:37 ` Winkler, Tomas
2013-09-10 16:47 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®