[RFC PATCH] hda_intel: ratelimit "spurious response" message

[RFC PATCH] hda_intel: ratelimit "spurious response" message

[Joe Perches]

dmesg here has a 100+ consecutive lines of:

[ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
...

Ratelimit the message to reduce the dmesg log noise.

Coalesce the format while at it.

Signed-off-by: Joe Perches <joe@perches.com>
---
 sound/pci/hda/hda_intel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 6e61a01..6e444ca 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -906,12 +906,12 @@ static void azx_update_rirb(struct azx *chip)
 			chip->rirb.res[addr] = res;
 			smp_wmb();
 			chip->rirb.cmds[addr]--;
-		} else
-			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, "
-				   "last cmd=%#08x\n",
+		} else if (printk_ratelimit()) {
+			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n",
 				   pci_name(chip->pci),
 				   res, res_ex,
 				   chip->last_cmd[addr]);
+		}
 	}
 }
 

Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message

[Takashi Iwai]

At Thu, 07 Nov 2013 11:55:15 -0800,
Joe Perches wrote:
> 
> dmesg here has a 100+ consecutive lines of:
> 
> [ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> [ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> [ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> ...
> 
> Ratelimit the message to reduce the dmesg log noise.
> 
> Coalesce the format while at it.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks, applied.

BTW, which hardware shows this problem?
I'm interested rather in that...


Takashi

> ---
>  sound/pci/hda/hda_intel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 6e61a01..6e444ca 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -906,12 +906,12 @@ static void azx_update_rirb(struct azx *chip)
>  			chip->rirb.res[addr] = res;
>  			smp_wmb();
>  			chip->rirb.cmds[addr]--;
> -		} else
> -			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, "
> -				   "last cmd=%#08x\n",
> +		} else if (printk_ratelimit()) {
> +			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n",
>  				   pci_name(chip->pci),
>  				   res, res_ex,
>  				   chip->last_cmd[addr]);
> +		}
>  	}
>  }
>  
> 
> 

Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message

[Joe Perches]

On Thu, 2013-11-07 at 21:23 +0100, Takashi Iwai wrote:
> At Thu, 07 Nov 2013 11:55:15 -0800,
> Joe Perches wrote:
> > 
> > dmesg here has a 100+ consecutive lines of:
> > 
> > [ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > [ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > [ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > ...
> > 
> > Ratelimit the message to reduce the dmesg log noise.
> > 
> > Coalesce the format while at it.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Thanks, applied.
> 
> BTW, which hardware shows this problem?
> I'm interested rather in that...

It's a little Acer netbook AO725

# lspci -v -v -s0:14.2
00:14.2 Audio device: Advanced Micro Devices, Inc. [AMD] FCH Azalia Controller (rev 01)
	Subsystem: Acer Incorporated [ALI] Device 0740
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
	Latency: 32, Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 46
	Region 0: Memory at f0240000 (64-bit, non-prefetchable) [size=16K]
	Capabilities: [50] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
		Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
	Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
		Address: 00000000fee0300c  Data: 41b3
	Kernel driver in use: snd_hda_intel

Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message

[Takashi Iwai]

At Thu, 07 Nov 2013 12:28:18 -0800,
Joe Perches wrote:
> 
> On Thu, 2013-11-07 at 21:23 +0100, Takashi Iwai wrote:
> > At Thu, 07 Nov 2013 11:55:15 -0800,
> > Joe Perches wrote:
> > > 
> > > dmesg here has a 100+ consecutive lines of:
> > > 
> > > [ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > > [ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > > [ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> > > ...
> > > 
> > > Ratelimit the message to reduce the dmesg log noise.
> > > 
> > > Coalesce the format while at it.
> > > 
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > 
> > Thanks, applied.
> > 
> > BTW, which hardware shows this problem?
> > I'm interested rather in that...
> 
> It's a little Acer netbook AO725
> 
> # lspci -v -v -s0:14.2
> 00:14.2 Audio device: Advanced Micro Devices, Inc. [AMD] FCH Azalia Controller (rev 01)
> 	Subsystem: Acer Incorporated [ALI] Device 0740

Could you give alsa-info.sh output (maybe better to get it after
applying your patch)?  It'll show more comprehensive information.


thanks,

Takashi