[PATCH] mfd: syscon: Allow to using subdevices

[PATCH] mfd: syscon: Allow to using subdevices

[Alexander Shiyan]

This patch adds support for using subdevices within syscon node.
Primary usage of this is describe all devices with same memory
region in one container.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/mfd/syscon.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index 71841f9..6e9244a 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, syscon);
 
+	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
+		dev_warn(dev, "Fail to create subdevices\n");
+
 	dev_info(dev, "regmap %pR registered\n", res);
 
 	return 0;
-- 
1.8.1.5

Re: [PATCH] mfd: syscon: Allow to using subdevices

[Lee Jones]

> This patch adds support for using subdevices within syscon node.
> Primary usage of this is describe all devices with same memory
> region in one container.

Can you show me an example where people have placed devices as
children to syscon?

> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/mfd/syscon.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 71841f9..6e9244a 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, syscon);
>  
> +	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
> +		dev_warn(dev, "Fail to create subdevices\n");
> +
>  	dev_info(dev, "regmap %pR registered\n", res);
>  
>  	return 0;
> -- 
> 1.8.1.5
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: syscon: Allow to using subdevices

[Mark Rutland]

On Thu, Nov 14, 2013 at 12:52:03PM +0000, Alexander Shiyan wrote:
> This patch adds support for using subdevices within syscon node.
> Primary usage of this is describe all devices with same memory
> region in one container.

I think if you need to do this, you should not be using syscon. What
exactly is your use-case?

I don't like the idea of treating syscon like a bus or container in this
fashion.

Mark.

> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/mfd/syscon.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 71841f9..6e9244a 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, syscon);
>  
> +	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
> +		dev_warn(dev, "Fail to create subdevices\n");
> +
>  	dev_info(dev, "regmap %pR registered\n", res);
>  
>  	return 0;
> -- 
> 1.8.1.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] mfd: syscon: Allow to using subdevices

[Alexander Shiyan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1414 bytes --]

Hello.

> On Thu, Nov 14, 2013 at 12:52:03PM +0000, Alexander Shiyan wrote:
> > This patch adds support for using subdevices within syscon node.
> > Primary usage of this is describe all devices with same memory
> > region in one container.
> 
> I think if you need to do this, you should not be using syscon. What
> exactly is your use-case?
> 
> I don't like the idea of treating syscon like a bus or container in this
> fashion.

Let me first show the new syscon-based driver. After a while, I'm going
to provide it. It will use the current way of getting syscon, i.e. through
syscon_regmap_lookup_by_phandle().

> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  drivers/mfd/syscon.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> > index 71841f9..6e9244a 100644
> > --- a/drivers/mfd/syscon.c
> > +++ b/drivers/mfd/syscon.c
> > @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
> >  
> >  	platform_set_drvdata(pdev, syscon);
> >  
> > +	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
> > +		dev_warn(dev, "Fail to create subdevices\n");
> > +
> >  	dev_info(dev, "regmap %pR registered\n", res);
> >  
> >  	return 0;
> > -- 

---
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥