From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 1/4] perf diff: don't compute Delta if he->dummy
Date: Thu, 21 Nov 2013 20:03:44 +0530 [thread overview]
Message-ID: <1385044427-13995-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1385044427-13995-1-git-send-email-artagnon@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/perf/builtin-diff.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 3b67ea2..79e0448 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -792,6 +792,9 @@ hpp__entry_pair(struct hist_entry *he, struct hist_entry *pair,
switch (idx) {
case PERF_HPP_DIFF__DELTA:
+ if (he->dummy)
+ break;
+
if (pair->diff.computed)
diff = pair->diff.period_ratio_delta;
else
--
1.8.5.rc0.5.g70ebc73.dirty
next prev parent reply other threads:[~2013-11-21 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:33 [PATCH 0/4] More color in 'perf diff' Ramkumar Ramachandra
2013-11-21 14:33 ` Ramkumar Ramachandra [this message]
2013-11-21 14:33 ` [PATCH 2/4] perf diff: give Delta column an appropriate color Ramkumar Ramachandra
2013-11-22 15:09 ` Jiri Olsa
2013-11-22 15:24 ` Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 3/4] perf diff: generalize hpp__color_delta for -c Ramkumar Ramachandra
2013-11-21 14:33 ` [INCOMPLETE PATCH 4/4] perf diff: give Ratio column an appropriate color Ramkumar Ramachandra
2013-11-22 15:10 ` Jiri Olsa
2013-11-22 15:14 ` Ramkumar Ramachandra
2013-11-22 15:14 ` Jiri Olsa
2013-11-24 6:32 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385044427-13995-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®