From: Jiri Olsa <jolsa@redhat.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 2/4] perf diff: give Delta column an appropriate color
Date: Fri, 22 Nov 2013 16:09:27 +0100 [thread overview]
Message-ID: <20131122150927.GA10881@krava.brq.redhat.com> (raw)
In-Reply-To: <1385044427-13995-3-git-send-email-artagnon@gmail.com>
On Thu, Nov 21, 2013 at 08:03:45PM +0530, Ramkumar Ramachandra wrote:
> Colorize the numbers in the Delta column either green or red depending
> on whether the it is positive or negative.
>
this patch changes the diff output for 'perf diff'
file '1' - old perf
file '2' - your change
I expected only the difference would be only color
not numbers.
thanks,
jirka
---
--- 1 2013-11-22 16:05:36.224136167 +0100
+++ 2 2013-11-22 16:05:40.399152889 +0100
@@ -9,128 +9,128 @@
11.78% -0.14% libc-2.17.so [.] fputs_unlocked
9.77% +0.02% libc-2.17.so [.] __GI___mempcpy
1.61% +0.21% yes [.] fputs_unlocked@plt
- 0.08% [kernel.kallsyms] [k] system_call
- 0.07% [kernel.kallsyms] [k] __srcu_read_lock
- 0.06% [kernel.kallsyms] [k] __srcu_read_unlock
+ 0.08% -0.01% [kernel.kallsyms] [k] system_call
+ 0.07% -0.01% [kernel.kallsyms] [k] __srcu_read_lock
+ 0.06% -0.01% [kernel.kallsyms] [k] __srcu_read_unlock
0.05% -0.03% [kernel.kallsyms] [k] native_write_msr_safe
0.04% -0.03% [kernel.kallsyms] [k] apic_timer_interrupt
- 0.04% libc-2.17.so [.] __GI___libc_write
- 0.04% [kernel.kallsyms] [k] __audit_syscall_exit
- 0.04% [kernel.kallsyms] [k] vfs_write
- 0.03% [kernel.kallsyms] [k] fget_light
- 0.03% [kernel.kallsyms] [k] __audit_syscall_entry
- 0.03% [kernel.kallsyms] [k] fsnotify
- 0.02% libc-2.17.so [.] _IO_do_write@@GLIBC_2.2.5
+ 0.04% +0.00% libc-2.17.so [.] __GI___libc_write
+ 0.04% +0.01% [kernel.kallsyms] [k] __audit_syscall_exit
+ 0.04% +0.00% [kernel.kallsyms] [k] vfs_write
+ 0.03% -0.01% [kernel.kallsyms] [k] fget_light
+ 0.03% -0.00% [kernel.kallsyms] [k] __audit_syscall_entry
+ 0.03% -0.00% [kernel.kallsyms] [k] fsnotify
+ 0.02% -0.00% libc-2.17.so [.] _IO_do_write@@GLIBC_2.2.5
0.02% +0.01% libc-2.17.so [.] _IO_file_write@@GLIBC_2.2.5
0.02% -0.01% [kernel.kallsyms] [k] task_tick_fair
- 0.02% libc-2.17.so [.] _IO_default_xsputn
+ 0.02% -0.00% libc-2.17.so [.] _IO_default_xsputn
0.02% -0.01% [kernel.kallsyms] [k] native_read_tsc
0.02% -0.01% [kernel.kallsyms] [k] _raw_spin_lock
- 0.01% libc-2.17.so [.] _IO_file_overflow@@GLIBC_2.2.5
- 0.01% [kernel.kallsyms] [k] do_timer
+ 0.01% -0.00% libc-2.17.so [.] _IO_file_overflow@@GLIBC_2.2.5
+ 0.01% -0.01% [kernel.kallsyms] [k] do_timer
0.01% -0.01% [kernel.kallsyms] [k] update_cfs_rq_blocked_load
- 0.01% [kernel.kallsyms] [k] sys_write
- 0.01% [kernel.kallsyms] [k] irqtime_account_irq
- 0.01% [kernel.kallsyms] [k] __fsnotify_parent
- 0.01% [kernel.kallsyms] [k] irqtime_account_process_tick.isra.2
- 0.01% [kernel.kallsyms] [k] native_read_msr_safe
- 0.01% [kernel.kallsyms] [k] rw_verify_area
- 0.01% [kernel.kallsyms] [k] sched_clock_cpu
- 0.01% [kernel.kallsyms] [k] rcu_check_callbacks
- 0.01% [kernel.kallsyms] [k] run_timer_softirq
- 0.01% [kernel.kallsyms] [k] path_put
- 0.01% [kernel.kallsyms] [k] unroll_tree_refs
- 0.01% [kernel.kallsyms] [k] hrtimer_interrupt
- 0.01% [kernel.kallsyms] [k] security_file_permission
- 0.01% [kernel.kallsyms] [k] kfree
- 0.01% [kernel.kallsyms] [k] native_sched_clock
- 0.01% [kernel.kallsyms] [k] _raw_spin_lock_irqsave
- 0.01% [kernel.kallsyms] [k] trigger_load_balance
- 0.01% [kernel.kallsyms] [k] update_cfs_shares
- 0.01% [kernel.kallsyms] [k] __acct_update_integrals
- 0.01% [kernel.kallsyms] [k] __update_cpu_load
- 0.01% [kernel.kallsyms] [k] __do_softirq
+ 0.01% +0.01% [kernel.kallsyms] [k] sys_write
+ 0.01% -0.00% [kernel.kallsyms] [k] irqtime_account_irq
+ 0.01% -0.00% [kernel.kallsyms] [k] __fsnotify_parent
+ 0.01% -0.01% [kernel.kallsyms] [k] irqtime_account_process_tick.isra.2
+ 0.01% +0.00% [kernel.kallsyms] [k] native_read_msr_safe
+ 0.01% +0.00% [kernel.kallsyms] [k] rw_verify_area
+ 0.01% -0.01% [kernel.kallsyms] [k] sched_clock_cpu
+ 0.01% -0.01% [kernel.kallsyms] [k] rcu_check_callbacks
+ 0.01% -0.01% [kernel.kallsyms] [k] run_timer_softirq
+ 0.01% -0.00% [kernel.kallsyms] [k] path_put
+ 0.01% -0.00% [kernel.kallsyms] [k] unroll_tree_refs
+ 0.01% -0.01% [kernel.kallsyms] [k] hrtimer_interrupt
+ 0.01% +0.00% [kernel.kallsyms] [k] security_file_permission
+ 0.01% +0.00% [kernel.kallsyms] [k] kfree
+ 0.01% -0.00% [kernel.kallsyms] [k] native_sched_clock
+ 0.01% -0.00% [kernel.kallsyms] [k] _raw_spin_lock_irqsave
+ 0.01% -0.00% [kernel.kallsyms] [k] trigger_load_balance
+ 0.01% -0.00% [kernel.kallsyms] [k] update_cfs_shares
+ 0.01% -0.00% [kernel.kallsyms] [k] __acct_update_integrals
next prev parent reply other threads:[~2013-11-22 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:33 [PATCH 0/4] More color in 'perf diff' Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 1/4] perf diff: don't compute Delta if he->dummy Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 2/4] perf diff: give Delta column an appropriate color Ramkumar Ramachandra
2013-11-22 15:09 ` Jiri Olsa [this message]
2013-11-22 15:24 ` Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 3/4] perf diff: generalize hpp__color_delta for -c Ramkumar Ramachandra
2013-11-21 14:33 ` [INCOMPLETE PATCH 4/4] perf diff: give Ratio column an appropriate color Ramkumar Ramachandra
2013-11-22 15:10 ` Jiri Olsa
2013-11-22 15:14 ` Ramkumar Ramachandra
2013-11-22 15:14 ` Jiri Olsa
2013-11-24 6:32 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122150927.GA10881@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®