From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: [INCOMPLETE PATCH 4/4] perf diff: give Ratio column an appropriate color
Date: Thu, 21 Nov 2013 20:03:47 +0530 [thread overview]
Message-ID: <1385044427-13995-5-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1385044427-13995-1-git-send-email-artagnon@gmail.com>
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
The incomplete bit is marked using a TODO; removing two trailing '%'
symbols doesn't seem to work. Can someone please tell me how to fix
this problem?
Thanks.
tools/perf/builtin-diff.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 4477aa2..844841e 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -786,6 +786,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
case COMPUTE_DELTA:
delta = pair->diff.period_ratio_delta;
break;
+ case COMPUTE_RATIO:
+ delta = pair->diff.period_ratio;
+ break;
default:
BUG_ON(1);
}
@@ -794,6 +797,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
case COMPUTE_DELTA:
delta = compute_delta(he, pair);
break;
+ case COMPUTE_RATIO:
+ delta = compute_ratio(he, pair);
+ break;
default:
BUG_ON(1);
}
@@ -806,6 +812,12 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
delta > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,
pfmt, delta);
break;
+ case COMPUTE_RATIO:
+ /* TODO: strip trailing % without breaking color */
+ scnprintf(pfmt, 20, "%%%d.6f%%%%", dfmt->header_width - 1);
+ return percent_color_snprintf(hpp->buf, hpp->size,
+ pfmt, delta);
+ break;
default:
BUG_ON(1);
}
@@ -821,6 +833,12 @@ static int hpp__color_delta(struct perf_hpp_fmt *fmt,
return __hpp__color_compare(fmt, hpp, he, COMPUTE_DELTA);
}
+static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
+ struct perf_hpp *hpp, struct hist_entry *he)
+{
+ return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
+}
+
static void
hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
{
@@ -1002,6 +1020,9 @@ static void data__hpp_register(struct data__file *d, int idx)
case PERF_HPP_DIFF__DELTA:
fmt->color = hpp__color_delta;
break;
+ case PERF_HPP_DIFF__RATIO:
+ fmt->color = hpp__color_ratio;
+ break;
default:
break;
}
--
1.8.5.rc0.5.g70ebc73.dirty
next prev parent reply other threads:[~2013-11-21 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:33 [PATCH 0/4] More color in 'perf diff' Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 1/4] perf diff: don't compute Delta if he->dummy Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 2/4] perf diff: give Delta column an appropriate color Ramkumar Ramachandra
2013-11-22 15:09 ` Jiri Olsa
2013-11-22 15:24 ` Ramkumar Ramachandra
2013-11-21 14:33 ` [PATCH 3/4] perf diff: generalize hpp__color_delta for -c Ramkumar Ramachandra
2013-11-21 14:33 ` Ramkumar Ramachandra [this message]
2013-11-22 15:10 ` [INCOMPLETE PATCH 4/4] perf diff: give Ratio column an appropriate color Jiri Olsa
2013-11-22 15:14 ` Ramkumar Ramachandra
2013-11-22 15:14 ` Jiri Olsa
2013-11-24 6:32 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385044427-13995-5-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®