From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Julien Grall <julien.grall@linaro.org>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers
Date: Tue, 3 Dec 2013 11:08:04 +0000 [thread overview]
Message-ID: <1386068884.13256.9.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <529DBA07.6090108@citrix.com>
On Tue, 2013-12-03 at 11:01 +0000, David Vrabel wrote:
> On 03/12/13 10:57, Roger Pau Monne wrote:
> > Using __packed__ on the public interface is not correct, this
> > structures should be compiled using the native ABI, and __packed__
> > should only be used in the backend counterpart of those structures
> > (which needs to handle different ABIs).
> >
> > This was even worse in the ARM case, where the Linux kernel was
> > incorrectly using the X86_32 protocol ABI. This patch fixes it, but
> > also breaks compatibility, so an ARM DomU kernel compiled with
> > this patch will fail to communicate with PV disk devices unless the
> > Dom0 also has this patch.
>
> This ABI change needs to be justified. Why do you think it is
> acceptable to break existing Linux guests? Because I don't think it is.
As I explained in my reply those guests are buggy.
Ian.
next prev parent reply other threads:[~2013-12-03 11:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:57 Roger Pau Monne
2013-12-03 11:01 ` David Vrabel
2013-12-03 11:07 ` [Xen-devel] " Paul Durrant
2013-12-03 11:08 ` Ian Campbell [this message]
2013-12-03 11:59 ` David Vrabel
2013-12-03 13:41 ` Ian Campbell
2013-12-03 15:11 ` David Vrabel
2013-12-03 15:17 ` Ian Campbell
2013-12-03 15:51 ` One Thousand Gnomes
2013-12-03 16:06 ` Ian Campbell
2013-12-03 20:11 ` Konrad Rzeszutek Wilk
2013-12-04 9:28 ` Ian Campbell
2013-12-04 9:43 ` Roger Pau Monné
2013-12-04 12:10 ` Ian Campbell
2013-12-04 11:03 ` Stefano Stabellini
2013-12-04 11:33 ` Stefano Stabellini
2013-12-11 16:18 ` Stefano Stabellini
2013-12-11 16:23 ` Roger Pau Monné
2013-12-11 16:29 ` Stefano Stabellini
2013-12-03 11:09 ` Roger Pau Monné
2013-12-03 11:05 ` [Xen-devel] " Ian Campbell
2013-12-03 11:11 ` Jan Beulich
2013-12-03 11:15 ` Ian Campbell
2013-12-03 11:14 ` Roger Pau Monné
2013-12-03 11:14 ` Jan Beulich
2013-12-03 11:18 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386068884.13256.9.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=julien.grall@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®