From: dietmar.eggemann@arm.com
To: peterz@infradead.org, mingo@redhat.com,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
chris.redpath@arm.com
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com
Subject: [RFC PATCH 6/8] sched: replace for_each_sd_topology with explicit for loop
Date: Fri, 13 Dec 2013 12:11:26 +0000 [thread overview]
Message-ID: <1386936688-29113-7-git-send-email-dietmar.eggemann@arm.com> (raw)
In-Reply-To: <1386936688-29113-1-git-send-email-dietmar.eggemann@arm.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
This patch prepares the scheduler domain level set up code to be able to
not rely on the default_topology[] any more.
The for_each_sd_topology macro is replaced with an explicit for loop
iterating over the sched_domain_topology array. It introduces the file
global variable sched_domains_levels to hold the number of scheduler
domain levels.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
---
kernel/sched/core.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 37febb067bad..897ff9222cab 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5379,9 +5379,7 @@ static struct sched_domain_topology_level default_topology[] = {
};
static struct sched_domain_topology_level *sched_domain_topology = default_topology;
-
-#define for_each_sd_topology(tl) \
- for (tl = sched_domain_topology; tl->init; tl++)
+static int sched_domains_levels;
#ifdef CONFIG_NUMA
@@ -5734,7 +5732,9 @@ static void sched_alloc(void)
}
#endif /* CONFIG_NUMA */
- tl = kzalloc((ARRAY_SIZE(default_topology) + level) *
+ sched_domains_levels = arch_sd_levels();
+
+ tl = kzalloc((sched_domains_levels + level) *
sizeof(struct sched_domain_topology_level), GFP_KERNEL);
if (!tl)
return;
@@ -5761,15 +5761,16 @@ static void sched_alloc(void)
}
sched_domains_numa_levels = level;
+ sched_domains_levels += level;
#endif /* CONFIG_NUMA */
}
static int __sdt_alloc(const struct cpumask *cpu_map)
{
- struct sched_domain_topology_level *tl;
- int j;
+ int i, j;
- for_each_sd_topology(tl) {
+ for (i = 0; i < sched_domains_levels; i++) {
+ struct sched_domain_topology_level *tl = &sched_domain_topology[i];
struct sd_data *sdd = &tl->data;
sdd->sd = alloc_percpu(struct sched_domain *);
@@ -5819,10 +5820,10 @@ static int __sdt_alloc(const struct cpumask *cpu_map)
static void __sdt_free(const struct cpumask *cpu_map)
{
- struct sched_domain_topology_level *tl;
- int j;
+ int i, j;
- for_each_sd_topology(tl) {
+ for (i = 0; i < sched_domains_levels; i++) {
+ struct sched_domain_topology_level *tl = &sched_domain_topology[i];
struct sd_data *sdd = &tl->data;
for_each_cpu(j, cpu_map) {
@@ -5887,10 +5888,10 @@ static int build_sched_domains(const struct cpumask *cpu_map,
/* Set up domains for cpus specified by the cpu_map. */
for_each_cpu(i, cpu_map) {
- struct sched_domain_topology_level *tl;
-
+ int y;
sd = NULL;
- for_each_sd_topology(tl) {
+ for (y = 0; y < sched_domains_levels; y++) {
+ struct sched_domain_topology_level *tl = &sched_domain_topology[y];
sd = build_sched_domain(tl, cpu_map, attr, sd, i);
if (tl == sched_domain_topology)
*per_cpu_ptr(d.sd, i) = sd;
--
1.7.9.5
next prev parent reply other threads:[~2013-12-13 12:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:11 [RFC PATCH 0/8] change scheduler domain hierarchy set-up dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 1/8] sched: arch interface for scheduler domain setup dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 2/8] arm: implement " dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 3/8] x86: " dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 4/8] sched: allocate the entire topology array dynamically dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 5/8] sched: introduce common topology level init function dietmar.eggemann
2013-12-20 14:04 ` Peter Zijlstra
2014-01-06 18:41 ` Dietmar Eggemann
2013-12-13 12:11 ` dietmar.eggemann [this message]
2013-12-13 12:11 ` [RFC PATCH 7/8] sched: replace topology level init func ptr with sd_init dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 8/8] sched: remove scheduler domain naming dietmar.eggemann
2013-12-20 14:08 ` Peter Zijlstra
2014-01-06 18:41 ` Dietmar Eggemann
2014-01-07 10:22 ` Peter Zijlstra
2014-01-07 14:33 ` Dietmar Eggemann
2013-12-20 14:00 ` [RFC PATCH 0/8] change scheduler domain hierarchy set-up Peter Zijlstra
2014-01-06 18:40 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386936688-29113-7-git-send-email-dietmar.eggemann@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=chris.redpath@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®