From: Peter Zijlstra <peterz@infradead.org>
To: dietmar.eggemann@arm.com
Cc: mingo@redhat.com, vincent.guittot@linaro.org,
morten.rasmussen@arm.com, chris.redpath@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 8/8] sched: remove scheduler domain naming
Date: Fri, 20 Dec 2013 15:08:42 +0100 [thread overview]
Message-ID: <20131220140842.GW16438@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <1386936688-29113-9-git-send-email-dietmar.eggemann@arm.com>
On Fri, Dec 13, 2013 at 12:11:28PM +0000, dietmar.eggemann@arm.com wrote:
> From: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
> In case the arch is allowed to define the conventional scheduler domain
> topology level (i.e. the one without SD_NUMA topology flag) layout, it is
> not feasible any more for the scheduler to name these levels. Therefore,
> this patch gets rid of of the sched_domain_topology_level structure
> member 'name' and the corresponding SD_INIT_NAME macro. It was only used
> when CONFIG_SCHED_DEBUG was set any way.
Right, so for debug purposes it might be convenient to keep it; we could
simply put it in the topology array, something like:
{ cpu_smt_mask, SD_SHARE_CPU_POWER | SD_SHARE_PKG_RESOURCE, SD_NAME(smt) },
which would still allow us to make it go away on !debug, but does
provide us with a nice label to print for the debug topology prints.
Alternatively we could do something like:
#define SD_mask(name, flags) \
{ cpu_##name##_mask, (flags), .name = #name }
to further reduce typing.
next prev parent reply other threads:[~2013-12-20 14:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:11 [RFC PATCH 0/8] change scheduler domain hierarchy set-up dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 1/8] sched: arch interface for scheduler domain setup dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 2/8] arm: implement " dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 3/8] x86: " dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 4/8] sched: allocate the entire topology array dynamically dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 5/8] sched: introduce common topology level init function dietmar.eggemann
2013-12-20 14:04 ` Peter Zijlstra
2014-01-06 18:41 ` Dietmar Eggemann
2013-12-13 12:11 ` [RFC PATCH 6/8] sched: replace for_each_sd_topology with explicit for loop dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 7/8] sched: replace topology level init func ptr with sd_init dietmar.eggemann
2013-12-13 12:11 ` [RFC PATCH 8/8] sched: remove scheduler domain naming dietmar.eggemann
2013-12-20 14:08 ` Peter Zijlstra [this message]
2014-01-06 18:41 ` Dietmar Eggemann
2014-01-07 10:22 ` Peter Zijlstra
2014-01-07 14:33 ` Dietmar Eggemann
2013-12-20 14:00 ` [RFC PATCH 0/8] change scheduler domain hierarchy set-up Peter Zijlstra
2014-01-06 18:40 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220140842.GW16438@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®