* [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs
@ 2013-12-15 3:35 dt.tangr
2013-12-15 3:35 ` [PATCH 2/3] arm: nspire: modify device tree to use the lsi,zevio-usb driver dt.tangr
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: dt.tangr @ 2013-12-15 3:35 UTC (permalink / raw)
To: linux-usb; +Cc: Daniel Tang, linux-kernel, Peter.Chen
From: Daniel Tang <dt.tangr@gmail.com>
The USB controller in TI-NSPIRE calculators (LSI Zevio SoC) are based off either
Freescale's USB OTG controller or the USB controller found in the IMX233, both
of which are Chipidea compatible.
This patch adds a device tree binding for the controller.
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
drivers/usb/chipidea/Makefile | 1 +
drivers/usb/chipidea/ci_hdrc_zevio.c | 72 ++++++++++++++++++++++++++++++++++
2 files changed, 73 insertions(+)
create mode 100644 drivers/usb/chipidea/ci_hdrc_zevio.c
diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
index a99d980..7635407 100644
--- a/drivers/usb/chipidea/Makefile
+++ b/drivers/usb/chipidea/Makefile
@@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_CHIPIDEA_DEBUG) += debug.o
# Glue/Bridge layers go here
obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o
+obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o
# PCI doesn't provide stubs, need to check
ifneq ($(CONFIG_PCI),)
diff --git a/drivers/usb/chipidea/ci_hdrc_zevio.c b/drivers/usb/chipidea/ci_hdrc_zevio.c
new file mode 100644
index 0000000..3bf6489
--- /dev/null
+++ b/drivers/usb/chipidea/ci_hdrc_zevio.c
@@ -0,0 +1,72 @@
+/*
+ * Copyright (C) 2013 Daniel Tang <tangrs@tangrs.id.au>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2, as
+ * published by the Free Software Foundation.
+ *
+ * Based off drivers/usb/chipidea/ci_hdrc_msm.c
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/usb/gadget.h>
+#include <linux/usb/chipidea.h>
+
+#include "ci.h"
+
+static struct ci_hdrc_platform_data ci_hdrc_zevio_platdata = {
+ .name = "ci_hdrc_zevio",
+ .flags = CI_HDRC_REGS_SHARED,
+ .capoffset = DEF_CAPOFFSET,
+};
+
+static int ci_hdrc_zevio_probe(struct platform_device *pdev)
+{
+ struct platform_device *ci_pdev;
+
+ dev_dbg(&pdev->dev, "ci_hdrc_zevio_probe\n");
+
+ ci_pdev = ci_hdrc_add_device(&pdev->dev,
+ pdev->resource, pdev->num_resources,
+ &ci_hdrc_zevio_platdata);
+
+ if (IS_ERR(ci_pdev)) {
+ dev_err(&pdev->dev, "ci_hdrc_add_device failed!\n");
+ return PTR_ERR(ci_pdev);
+ }
+
+ platform_set_drvdata(pdev, ci_pdev);
+
+ return 0;
+}
+
+static int ci_hdrc_zevio_remove(struct platform_device *pdev)
+{
+ struct platform_device *ci_pdev = platform_get_drvdata(pdev);
+
+ ci_hdrc_remove_device(ci_pdev);
+
+ return 0;
+}
+
+static const struct of_device_id ci_hdrc_zevio_dt_ids[] = {
+ { .compatible = "lsi,zevio-usb", },
+ { /* sentinel */ }
+};
+
+static struct platform_driver ci_hdrc_zevio_driver = {
+ .probe = ci_hdrc_zevio_probe,
+ .remove = ci_hdrc_zevio_remove,
+ .driver = {
+ .name = "zevio_usb",
+ .owner = THIS_MODULE,
+ .of_match_table = ci_hdrc_zevio_dt_ids,
+ },
+};
+
+MODULE_DEVICE_TABLE(of, ci_hdrc_zevio_dt_ids);
+module_platform_driver(ci_hdrc_zevio_driver);
+
+MODULE_LICENSE("GPL v2");
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] arm: nspire: modify device tree to use the lsi,zevio-usb driver
2013-12-15 3:35 [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs dt.tangr
@ 2013-12-15 3:35 ` dt.tangr
2013-12-15 3:35 ` [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb dt.tangr
2013-12-16 1:19 ` [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs Peter Chen
2 siblings, 0 replies; 6+ messages in thread
From: dt.tangr @ 2013-12-15 3:35 UTC (permalink / raw)
To: linux-usb; +Cc: Daniel Tang, linux-kernel, devicetree, linux-arm-kernel, linux
From: Daniel Tang <dt.tangr@gmail.com>
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
arch/arm/boot/dts/nspire.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi
index a22ffe6..012c6d1 100644
--- a/arch/arm/boot/dts/nspire.dtsi
+++ b/arch/arm/boot/dts/nspire.dtsi
@@ -65,6 +65,7 @@
};
usb0: usb@B0000000 {
+ compatible = "lsi,zevio-usb";
reg = <0xB0000000 0x1000>;
interrupts = <8>;
};
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb
2013-12-15 3:35 [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs dt.tangr
2013-12-15 3:35 ` [PATCH 2/3] arm: nspire: modify device tree to use the lsi,zevio-usb driver dt.tangr
@ 2013-12-15 3:35 ` dt.tangr
2013-12-16 13:46 ` Rob Herring
2013-12-16 1:19 ` [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs Peter Chen
2 siblings, 1 reply; 6+ messages in thread
From: dt.tangr @ 2013-12-15 3:35 UTC (permalink / raw)
To: linux-usb; +Cc: Daniel Tang, linux-kernel, devicetree, linux-doc
From: Daniel Tang <dt.tangr@gmail.com>
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
.../devicetree/bindings/usb/ci-hdrc-zevio.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
new file mode 100644
index 0000000..1a005eb
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
@@ -0,0 +1,17 @@
+* LSI Zevio USB OTG Controller
+
+Required properties:
+- compatible: Should be "lsi,zevio-usb"
+- reg: Should contain registers location and length
+- interrupts: Should contain controller interrupt
+
+Recommended properies:
+- vbus-supply: regulator for vbus
+
+Examples:
+ usb0: usb@B0000000 {
+ reg = <0xB0000000 0x1000>;
+ compatible = "lsi,zevio-usb";
+ interrupts = <8>;
+ vbus-supply = <&vbus_reg>;
+ };
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb
2013-12-15 3:35 ` [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb dt.tangr
@ 2013-12-16 13:46 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2013-12-16 13:46 UTC (permalink / raw)
To: dt.tangr; +Cc: Linux USB List, linux-kernel, devicetree, linux-doc
On Sat, Dec 14, 2013 at 9:35 PM, <dt.tangr@gmail.com> wrote:
> From: Daniel Tang <dt.tangr@gmail.com>
>
>
> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
A few minor things below. Otherwise:
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> .../devicetree/bindings/usb/ci-hdrc-zevio.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
> new file mode 100644
> index 0000000..1a005eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt
> @@ -0,0 +1,17 @@
> +* LSI Zevio USB OTG Controller
> +
> +Required properties:
> +- compatible: Should be "lsi,zevio-usb"
> +- reg: Should contain registers location and length
> +- interrupts: Should contain controller interrupt
> +
> +Recommended properies:
To be consistent, should be "optional" rather than recommended.
s/properies/properties/
> +- vbus-supply: regulator for vbus
> +
> +Examples:
> + usb0: usb@B0000000 {
> + reg = <0xB0000000 0x1000>;
lower case hex is preferred.
> + compatible = "lsi,zevio-usb";
> + interrupts = <8>;
> + vbus-supply = <&vbus_reg>;
> + };
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs
2013-12-15 3:35 [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs dt.tangr
2013-12-15 3:35 ` [PATCH 2/3] arm: nspire: modify device tree to use the lsi,zevio-usb driver dt.tangr
2013-12-15 3:35 ` [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb dt.tangr
@ 2013-12-16 1:19 ` Peter Chen
2013-12-16 2:07 ` Daniel Tang
2 siblings, 1 reply; 6+ messages in thread
From: Peter Chen @ 2013-12-16 1:19 UTC (permalink / raw)
To: dt.tangr; +Cc: linux-usb, linux-kernel
On Sun, Dec 15, 2013 at 02:35:07PM +1100, dt.tangr@gmail.com wrote:
> From: Daniel Tang <dt.tangr@gmail.com>
>
> The USB controller in TI-NSPIRE calculators (LSI Zevio SoC) are based off either
> Freescale's USB OTG controller or the USB controller found in the IMX233, both
> of which are Chipidea compatible.
>
> This patch adds a device tree binding for the controller.
>
> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
> ---
> drivers/usb/chipidea/Makefile | 1 +
> drivers/usb/chipidea/ci_hdrc_zevio.c | 72 ++++++++++++++++++++++++++++++++++
> 2 files changed, 73 insertions(+)
> create mode 100644 drivers/usb/chipidea/ci_hdrc_zevio.c
>
> diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
> index a99d980..7635407 100644
> --- a/drivers/usb/chipidea/Makefile
> +++ b/drivers/usb/chipidea/Makefile
> @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_CHIPIDEA_DEBUG) += debug.o
> # Glue/Bridge layers go here
>
> obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o
> +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o
>
> # PCI doesn't provide stubs, need to check
> ifneq ($(CONFIG_PCI),)
> diff --git a/drivers/usb/chipidea/ci_hdrc_zevio.c b/drivers/usb/chipidea/ci_hdrc_zevio.c
> new file mode 100644
> index 0000000..3bf6489
> --- /dev/null
> +++ b/drivers/usb/chipidea/ci_hdrc_zevio.c
> @@ -0,0 +1,72 @@
> +/*
> + * Copyright (C) 2013 Daniel Tang <tangrs@tangrs.id.au>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2, as
> + * published by the Free Software Foundation.
> + *
> + * Based off drivers/usb/chipidea/ci_hdrc_msm.c
> + *
> + */
> +
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/usb/gadget.h>
> +#include <linux/usb/chipidea.h>
> +
> +#include "ci.h"
> +
> +static struct ci_hdrc_platform_data ci_hdrc_zevio_platdata = {
> + .name = "ci_hdrc_zevio",
> + .flags = CI_HDRC_REGS_SHARED,
> + .capoffset = DEF_CAPOFFSET,
> +};
> +
> +static int ci_hdrc_zevio_probe(struct platform_device *pdev)
> +{
> + struct platform_device *ci_pdev;
> +
> + dev_dbg(&pdev->dev, "ci_hdrc_zevio_probe\n");
> +
> + ci_pdev = ci_hdrc_add_device(&pdev->dev,
> + pdev->resource, pdev->num_resources,
> + &ci_hdrc_zevio_platdata);
> +
> + if (IS_ERR(ci_pdev)) {
> + dev_err(&pdev->dev, "ci_hdrc_add_device failed!\n");
> + return PTR_ERR(ci_pdev);
> + }
> +
> + platform_set_drvdata(pdev, ci_pdev);
> +
> + return 0;
> +}
> +
> +static int ci_hdrc_zevio_remove(struct platform_device *pdev)
> +{
> + struct platform_device *ci_pdev = platform_get_drvdata(pdev);
> +
> + ci_hdrc_remove_device(ci_pdev);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id ci_hdrc_zevio_dt_ids[] = {
> + { .compatible = "lsi,zevio-usb", },
> + { /* sentinel */ }
> +};
> +
> +static struct platform_driver ci_hdrc_zevio_driver = {
> + .probe = ci_hdrc_zevio_probe,
> + .remove = ci_hdrc_zevio_remove,
> + .driver = {
> + .name = "zevio_usb",
> + .owner = THIS_MODULE,
> + .of_match_table = ci_hdrc_zevio_dt_ids,
> + },
> +};
> +
> +MODULE_DEVICE_TABLE(of, ci_hdrc_zevio_dt_ids);
> +module_platform_driver(ci_hdrc_zevio_driver);
> +
> +MODULE_LICENSE("GPL v2");
> --
The driver patch is okay for me, please cc me your dt patch next
time, I will apply it when your dt patches are applied by
dt maintainer (or any of your dt strings "zevio_xxx" are applied).
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-16 13:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-15 3:35 [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs dt.tangr
2013-12-15 3:35 ` [PATCH 2/3] arm: nspire: modify device tree to use the lsi,zevio-usb driver dt.tangr
2013-12-15 3:35 ` [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb dt.tangr
2013-12-16 13:46 ` Rob Herring
2013-12-16 1:19 ` [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs Peter Chen
2013-12-16 2:07 ` Daniel Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®