From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: [PATCH 5/7] sched: pass struct rq to rebalance_domains function
Date: Mon, 30 Dec 2013 14:44:51 +0100 [thread overview]
Message-ID: <1388411093-3413-6-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1388411093-3413-1-git-send-email-daniel.lezcano@linaro.org>
The cpu information is stored in the struct rq and the caller of the
rebalance_domains function pass the cpu to retrieve the struct rq but
it already has the struct rq info. Replace the cpu parameter with the
struct rq.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
kernel/sched/fair.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c647c45..0fbd8d0 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6633,10 +6633,10 @@ void update_max_interval(void)
*
* Balancing parameters are set up in init_sched_domains.
*/
-static void rebalance_domains(int cpu, enum cpu_idle_type idle)
+static void rebalance_domains(struct rq *rq, enum cpu_idle_type idle)
{
int continue_balancing = 1;
- struct rq *rq = cpu_rq(cpu);
+ int cpu = rq->cpu;
unsigned long interval;
struct sched_domain *sd;
/* Earliest time when we have to do rebalance again */
@@ -6762,7 +6762,7 @@ static void nohz_idle_balance(int this_cpu, enum cpu_idle_type idle)
update_idle_cpu_load(rq);
raw_spin_unlock_irq(&rq->lock);
- rebalance_domains(balance_cpu, CPU_IDLE);
+ rebalance_domains(rq, CPU_IDLE);
if (time_after(this_rq->next_balance, rq->next_balance))
this_rq->next_balance = rq->next_balance;
@@ -6851,7 +6851,7 @@ static void run_rebalance_domains(struct softirq_action *h)
enum cpu_idle_type idle = this_rq->idle_balance ?
CPU_IDLE : CPU_NOT_IDLE;
- rebalance_domains(this_cpu, idle);
+ rebalance_domains(this_rq, idle);
/*
* If this cpu has a pending nohz_balance_kick, then do the
--
1.7.9.5
next prev parent reply other threads:[~2013-12-30 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 13:44 [PATCH 0/7] sched: cleanup trigger_load_balance Daniel Lezcano
2013-12-30 13:44 ` [PATCH 1/7] sched: reduce nohz_kick_needed parameters Daniel Lezcano
2013-12-30 13:44 ` [PATCH 2/7] sched: pass struct rq to on_null_domain function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 3/7] sched: remove unused parameter for find_new_ilb Daniel Lezcano
2013-12-30 13:44 ` [PATCH 4/7] sched: remove unused parameter in nohz_balancer_kick function Daniel Lezcano
[not found] ` <CAM4v1pP1=NaKcqki4yh=7gpyRJp8PD4UkQfXwFtd=LTnn7s5Pg@mail.gmail.com>
2013-12-31 15:02 ` Daniel Lezcano
2013-12-30 13:44 ` Daniel Lezcano [this message]
2013-12-30 13:44 ` [PATCH 6/7] sched: pass struct rq to nohz_idle_balance function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 7/7] sched: factor out on_null_domain check in trigger_load_balance function Daniel Lezcano
2013-12-31 16:28 ` [PATCH 0/7] sched: cleanup trigger_load_balance Peter Zijlstra
2013-12-31 17:19 ` Daniel Lezcano
2014-01-06 11:03 ` Peter Zijlstra
2014-01-06 11:25 ` Daniel Lezcano
2014-01-06 11:31 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388411093-3413-6-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome