mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: [PATCH 7/7] sched: factor out on_null_domain check in trigger_load_balance function
Date: Mon, 30 Dec 2013 14:44:53 +0100	[thread overview]
Message-ID: <1388411093-3413-8-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1388411093-3413-1-git-send-email-daniel.lezcano@linaro.org>

The test on_null_domain is done twice in the trigger_load_balance function.

Move the test at the begin of the function, so there is only one check.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 kernel/sched/fair.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 59c57e7..ef95ddf 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6871,11 +6871,13 @@ static inline int on_null_domain(struct rq *rq)
 void trigger_load_balance(struct rq *rq)
 {
 	/* Don't need to rebalance while attached to NULL domain */
-	if (time_after_eq(jiffies, rq->next_balance) &&
-	    likely(!on_null_domain(rq)))
+	if (unlikely(on_null_domain(rq)))
+		return;
+
+	if (time_after_eq(jiffies, rq->next_balance))
 		raise_softirq(SCHED_SOFTIRQ);
 #ifdef CONFIG_NO_HZ_COMMON
-	if (nohz_kick_needed(rq) && likely(!on_null_domain(rq)))
+	if (nohz_kick_needed(rq))
 		nohz_balancer_kick();
 #endif
 }
-- 
1.7.9.5


  parent reply	other threads:[~2013-12-30 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 13:44 [PATCH 0/7] sched: cleanup trigger_load_balance Daniel Lezcano
2013-12-30 13:44 ` [PATCH 1/7] sched: reduce nohz_kick_needed parameters Daniel Lezcano
2013-12-30 13:44 ` [PATCH 2/7] sched: pass struct rq to on_null_domain function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 3/7] sched: remove unused parameter for find_new_ilb Daniel Lezcano
2013-12-30 13:44 ` [PATCH 4/7] sched: remove unused parameter in nohz_balancer_kick function Daniel Lezcano
     [not found]   ` <CAM4v1pP1=NaKcqki4yh=7gpyRJp8PD4UkQfXwFtd=LTnn7s5Pg@mail.gmail.com>
2013-12-31 15:02     ` Daniel Lezcano
2013-12-30 13:44 ` [PATCH 5/7] sched: pass struct rq to rebalance_domains function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 6/7] sched: pass struct rq to nohz_idle_balance function Daniel Lezcano
2013-12-30 13:44 ` Daniel Lezcano [this message]
2013-12-31 16:28 ` [PATCH 0/7] sched: cleanup trigger_load_balance Peter Zijlstra
2013-12-31 17:19   ` Daniel Lezcano
2014-01-06 11:03     ` Peter Zijlstra
2014-01-06 11:25       ` Daniel Lezcano
2014-01-06 11:31         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388411093-3413-8-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome