From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 0/7] sched: cleanup trigger_load_balance
Date: Mon, 6 Jan 2014 12:03:51 +0100 [thread overview]
Message-ID: <20140106110351.GE31570@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <52C2FC88.6040903@linaro.org>
On Tue, Dec 31, 2013 at 06:19:04PM +0100, Daniel Lezcano wrote:
> I understand. Happy new year !
Happy new year to you too! :-)
> ps : the patchset is based on tip/sched/core
Weird; because tip/sched/core as per today looks like:
029632fbb7b7c kernel/sched_fair.c (Peter Zijlstra 2011-10-25 10:00:11 +0200 6872) void trigger_load_balance(struct rq *rq, int cpu)
And your patches assume it looks like:
Patch 1: @@ -6878,7 +6878,7 @@ void trigger_load_balance(struct rq *rq)
Patch 2: @@ -6875,10 +6875,10 @@ void trigger_load_balance(struct rq *rq)
Patch 4:
void trigger_load_balance(struct rq *rq)
{
- int cpu = rq->cpu;
-
Which obviously doesn't quite work..
So I can make it fit.. but I do wonder what I'm missing here..
next prev parent reply other threads:[~2014-01-06 11:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 13:44 Daniel Lezcano
2013-12-30 13:44 ` [PATCH 1/7] sched: reduce nohz_kick_needed parameters Daniel Lezcano
2013-12-30 13:44 ` [PATCH 2/7] sched: pass struct rq to on_null_domain function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 3/7] sched: remove unused parameter for find_new_ilb Daniel Lezcano
2013-12-30 13:44 ` [PATCH 4/7] sched: remove unused parameter in nohz_balancer_kick function Daniel Lezcano
[not found] ` <CAM4v1pP1=NaKcqki4yh=7gpyRJp8PD4UkQfXwFtd=LTnn7s5Pg@mail.gmail.com>
2013-12-31 15:02 ` Daniel Lezcano
2013-12-30 13:44 ` [PATCH 5/7] sched: pass struct rq to rebalance_domains function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 6/7] sched: pass struct rq to nohz_idle_balance function Daniel Lezcano
2013-12-30 13:44 ` [PATCH 7/7] sched: factor out on_null_domain check in trigger_load_balance function Daniel Lezcano
2013-12-31 16:28 ` [PATCH 0/7] sched: cleanup trigger_load_balance Peter Zijlstra
2013-12-31 17:19 ` Daniel Lezcano
2014-01-06 11:03 ` Peter Zijlstra [this message]
2014-01-06 11:25 ` Daniel Lezcano
2014-01-06 11:31 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106110351.GE31570@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome