* [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c
@ 2014-01-10 14:29 Paul Gortmaker
2014-01-12 17:18 ` Hans-Christian Egtvedt
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2014-01-10 14:29 UTC (permalink / raw)
To: linux-kernel
Cc: Fengguang Wu, Paul Gortmaker, Haavard Skinnemoen, Hans-Christian Egtvedt
Causing this:
In file included from arch/avr32/boards/mimc200/fram.c:13:
include/linux/miscdevice.h:51: error: field 'list' has incomplete type
include/linux/miscdevice.h:55: error: expected specifier-qualifier-list before 'mode_t'
arch/avr32/boards/mimc200/fram.c:42: error: 'THIS_MODULE' undeclared here (not in a function)
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
index 9764a1a1073e..c1466a872b9c 100644
--- a/arch/avr32/boards/mimc200/fram.c
+++ b/arch/avr32/boards/mimc200/fram.c
@@ -11,6 +11,7 @@
#define FRAM_VERSION "1.0"
#include <linux/miscdevice.h>
+#include <linux/module.h>
#include <linux/proc_fs.h>
#include <linux/mm.h>
#include <linux/io.h>
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c
2014-01-10 14:29 [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c Paul Gortmaker
@ 2014-01-12 17:18 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 2+ messages in thread
From: Hans-Christian Egtvedt @ 2014-01-12 17:18 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, Fengguang Wu, Haavard Skinnemoen
Around Fri 10 Jan 2014 09:29:39 -0500 or thereabout, Paul Gortmaker wrote:
> Causing this:
>
> In file included from arch/avr32/boards/mimc200/fram.c:13:
> include/linux/miscdevice.h:51: error: field 'list' has incomplete type
> include/linux/miscdevice.h:55: error: expected specifier-qualifier-list before 'mode_t'
> arch/avr32/boards/mimc200/fram.c:42: error: 'THIS_MODULE' undeclared here (not in a function)
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thank you for fixing, almost identical to Sergei Trofimovich patch, which
appeared first in my inbox.
Fix appended to the AVR32 tree.
> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a1073e..c1466a872b9c 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -11,6 +11,7 @@
> #define FRAM_VERSION "1.0"
>
> #include <linux/miscdevice.h>
> +#include <linux/module.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> #include <linux/io.h>
--
mvh
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-12 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-10 14:29 [PATCH] avr32: fix missing module.h causing build failure in mimc200/fram.c Paul Gortmaker
2014-01-12 17:18 ` Hans-Christian Egtvedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®