[PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Fix the following checkpatch error and warning:

ERROR: switch and case should be at the same indent
#311: FILE: drivers/regulator/pfuze100-regulator.c:311:
+	switch (value & 0x0f) {
[...]
+		case 0x8:
[...]
+		case 0x0:
[...]
+		default:

WARNING: line over 80 characters
#312: FILE: drivers/regulator/pfuze100-regulator.c:312:
+		/* Freescale misprogrammed 1-3% of parts prior to week 8 of 2013 as ID=8 */

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/regulator/pfuze100-regulator.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 0c511ae..ac01ad2 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
 		return ret;
 
 	switch (value & 0x0f) {
-		/* Freescale misprogrammed 1-3% of parts prior to week 8 of 2013 as ID=8 */
-		case 0x8:
-			dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");
-		case 0x0:
-			break;
-		default:
-			dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);
-			return -ENODEV;
+	/*
+	 * Freescale misprogrammed 1-3% of parts prior to week 8 of 2013
+	 * as ID=8
+	 */
+	case 0x8:
+		dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");
+	case 0x0:
+		break;
+	default:
+		dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);
+		return -ENODEV;
 	}
 
 	ret = regmap_read(pfuze_chip->regmap, PFUZE100_REVID, &value);
-- 
1.8.1.2

Re: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[Joe Perches]

On Wed, 2014-01-15 at 00:52 -0200, Fabio Estevam wrote:
> Fix the following checkpatch error and warning:

While you're at it:

> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
[]
> @@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
[]
> +	case 0x8:
> +		dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");

missing "\n" terminating newline and
missing break (or fallthrough comment)

> +	case 0x0:
> +		break;
> +	default:
> +		dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);

invalid vs illegal

Re: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

On Wed, Jan 15, 2014 at 12:52:45AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Fix the following checkpatch error and warning:

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[Fabio Estevam]

On Wed, Jan 15, 2014 at 1:02 AM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-01-15 at 00:52 -0200, Fabio Estevam wrote:
>> Fix the following checkpatch error and warning:
>
> While you're at it:
>
>> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> []
>> @@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
> []
>> +     case 0x8:
>> +             dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");
>
> missing "\n" terminating newline and
> missing break (or fallthrough comment)
>
>> +     case 0x0:
>> +             break;
>> +     default:
>> +             dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);
>
> invalid vs illegal

Thanks, Joe.

Will address your suggestions through a different patch.

Regards,

Fabio Estevam