mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sagar.a.kamble@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: vijay.a.purushothaman@intel.com, airlied@linux.ie,
	daniel.vetter@ffwll.ch, jani.nikula@linux.intel.com,
	tomi.valkeinen@ti.com, airlied@redhat.com, robdclark@gmail.com,
	archit@ti.com, gregkh@linuxfoundation.org, joe@perches.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	ville.syrjala@linux.intel.com
Subject: [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask()
Date: Fri,  7 Feb 2014 19:15:07 +0530	[thread overview]
Message-ID: <1391780716-21896-3-git-send-email-sagar.a.kamble@intel.com> (raw)
In-Reply-To: <1391780716-21896-1-git-send-email-sagar.a.kamble@intel.com>

From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Make drm_property_create_bitmask() a bit more generic by allowing the
caller to specify which bits are in fact supported. This allows multiple
callers to use the same enum list, but still create different versions
of the same property with different list of supported bits.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Sagar Kamble <sagar.a.kamble@intel.com>
---
 drivers/gpu/drm/drm_crtc.c | 6 +++++-
 include/drm/drm_crtc.h     | 3 ++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 3b7d32d..628d3d3 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -2906,7 +2906,8 @@ EXPORT_SYMBOL(drm_property_create_enum);
 struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
 					 int flags, const char *name,
 					 const struct drm_prop_enum_list *props,
-					 int num_values)
+					 int num_values,
+					 unsigned int supported_bits)
 {
 	struct drm_property *property;
 	int i, ret;
@@ -2918,6 +2919,9 @@ struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
 		return NULL;
 
 	for (i = 0; i < num_values; i++) {
+		if (!(supported_bits & (1 << i)))
+			continue;
+
 		ret = drm_property_add_enum(property, i,
 				      props[i].type,
 				      props[i].name);
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index d5c46c1..41b86d2 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1070,7 +1070,8 @@ extern struct drm_property *drm_property_create_enum(struct drm_device *dev, int
 struct drm_property *drm_property_create_bitmask(struct drm_device *dev,
 					 int flags, const char *name,
 					 const struct drm_prop_enum_list *props,
-					 int num_values);
+					 int num_values,
+					 unsigned int supported_bits);
 struct drm_property *drm_property_create_range(struct drm_device *dev, int flags,
 					 const char *name,
 					 uint64_t min, uint64_t max);
-- 
1.8.5


  parent reply	other threads:[~2014-02-07 13:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 13:45 [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sagar.a.kamble
2014-02-07 13:45 ` sagar.a.kamble [this message]
2014-02-09 13:37   ` [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask() Rob Clark
2014-02-07 13:45 ` [PATCH v4 03/11] drm: Add drm_mode_create_rotation_property() sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sagar.a.kamble
2014-02-09 13:34   ` Rob Clark
2014-02-07 13:45 ` [PATCH v4 05/11] drm: Add drm_rect rotation functions sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 06/11] drm: Add drm_rotation_simplify() sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 07/11] drm/i915: Add 180 degree sprite rotation support sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 08/11] drm/i915: Make intel_plane_restore() return an error sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 09/11] drm/i915: Add rotation property for sprites sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 10/11] drm/i915: Add 180 degree primary plane rotation support sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping sagar.a.kamble
2014-02-07 15:04 ` [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes Daniel Vetter
2014-02-10 10:41 ` One Thousand Gnomes
2014-02-10 13:52   ` Ville Syrjälä
2014-02-10 14:14     ` One Thousand Gnomes
2014-02-10 14:29       ` Ville Syrjälä
2014-02-10 17:31         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391780716-21896-3-git-send-email-sagar.a.kamble@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=archit@ti.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vijay.a.purushothaman@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®