From: sagar.a.kamble@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: vijay.a.purushothaman@intel.com, airlied@linux.ie,
daniel.vetter@ffwll.ch, jani.nikula@linux.intel.com,
tomi.valkeinen@ti.com, airlied@redhat.com, robdclark@gmail.com,
archit@ti.com, gregkh@linuxfoundation.org, joe@perches.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v4 08/11] drm/i915: Make intel_plane_restore() return an error
Date: Fri, 7 Feb 2014 19:15:13 +0530 [thread overview]
Message-ID: <1391780716-21896-9-git-send-email-sagar.a.kamble@intel.com> (raw)
In-Reply-To: <1391780716-21896-1-git-send-email-sagar.a.kamble@intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Propagate the error from intel_update_plane() up through
intel_plane_restore() to the caller. This will be used for
rollback purposes when setting properties fails.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Sagar Kamble <sagar.a.kamble@intel.com>
---
drivers/gpu/drm/i915/intel_drv.h | 2 +-
drivers/gpu/drm/i915/intel_sprite.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 85864fc..7a79b8e 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -897,7 +897,7 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob);
int intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane);
void intel_flush_primary_plane(struct drm_i915_private *dev_priv,
enum plane plane);
-void intel_plane_restore(struct drm_plane *plane);
+int intel_plane_restore(struct drm_plane *plane);
void intel_plane_disable(struct drm_plane *plane);
int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
struct drm_file *file_priv);
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 477d4d7..511934c 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1047,18 +1047,18 @@ out_unlock:
return ret;
}
-void intel_plane_restore(struct drm_plane *plane)
+int intel_plane_restore(struct drm_plane *plane)
{
struct intel_plane *intel_plane = to_intel_plane(plane);
if (!plane->crtc || !plane->fb)
- return;
+ return 0;
- intel_update_plane(plane, plane->crtc, plane->fb,
- intel_plane->crtc_x, intel_plane->crtc_y,
- intel_plane->crtc_w, intel_plane->crtc_h,
- intel_plane->src_x, intel_plane->src_y,
- intel_plane->src_w, intel_plane->src_h);
+ return intel_update_plane(plane, plane->crtc, plane->fb,
+ intel_plane->crtc_x, intel_plane->crtc_y,
+ intel_plane->crtc_w, intel_plane->crtc_h,
+ intel_plane->src_x, intel_plane->src_y,
+ intel_plane->src_w, intel_plane->src_h);
}
void intel_plane_disable(struct drm_plane *plane)
--
1.8.5
next prev parent reply other threads:[~2014-02-07 13:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 13:45 [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask() sagar.a.kamble
2014-02-09 13:37 ` Rob Clark
2014-02-07 13:45 ` [PATCH v4 03/11] drm: Add drm_mode_create_rotation_property() sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sagar.a.kamble
2014-02-09 13:34 ` Rob Clark
2014-02-07 13:45 ` [PATCH v4 05/11] drm: Add drm_rect rotation functions sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 06/11] drm: Add drm_rotation_simplify() sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 07/11] drm/i915: Add 180 degree sprite rotation support sagar.a.kamble
2014-02-07 13:45 ` sagar.a.kamble [this message]
2014-02-07 13:45 ` [PATCH v4 09/11] drm/i915: Add rotation property for sprites sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 10/11] drm/i915: Add 180 degree primary plane rotation support sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping sagar.a.kamble
2014-02-07 15:04 ` [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes Daniel Vetter
2014-02-10 10:41 ` One Thousand Gnomes
2014-02-10 13:52 ` Ville Syrjälä
2014-02-10 14:14 ` One Thousand Gnomes
2014-02-10 14:29 ` Ville Syrjälä
2014-02-10 17:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391780716-21896-9-git-send-email-sagar.a.kamble@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=archit@ti.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=vijay.a.purushothaman@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®