mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sagar.a.kamble@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: vijay.a.purushothaman@intel.com, airlied@linux.ie,
	daniel.vetter@ffwll.ch, jani.nikula@linux.intel.com,
	tomi.valkeinen@ti.com, airlied@redhat.com, robdclark@gmail.com,
	archit@ti.com, gregkh@linuxfoundation.org, joe@perches.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	ville.syrjala@linux.intel.com,
	Sagar Kamble <sagar.a.kamble@intel.com>
Subject: [PATCH v4 03/11] drm: Add drm_mode_create_rotation_property()
Date: Fri,  7 Feb 2014 19:15:08 +0530	[thread overview]
Message-ID: <1391780716-21896-4-git-send-email-sagar.a.kamble@intel.com> (raw)
In-Reply-To: <1391780716-21896-1-git-send-email-sagar.a.kamble@intel.com>

From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Add a function to create a standards compliant rotation property.

v4: For creating rotation bitmask property send number of values
as only number of set rotations

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
Tested-by: Sagar Kamble <sagar.a.kamble@intel.com>
---
 drivers/gpu/drm/drm_crtc.c | 33 +++++++++++++++++++++++++++++++++
 include/drm/drm_crtc.h     |  2 ++
 2 files changed, 35 insertions(+)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 628d3d3..e7bbbad 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4118,3 +4118,36 @@ void drm_mode_config_cleanup(struct drm_device *dev)
 	idr_destroy(&dev->mode_config.crtc_idr);
 }
 EXPORT_SYMBOL(drm_mode_config_cleanup);
+
+/*
+* Function to get number of bits set in bitmask
+* using Brian Kernighan's Algorithm
+*/
+unsigned int bits_set(unsigned int n)
+{
+	unsigned int count = 0;
+
+	while (n) {
+		n &= (n-1);
+		count ++;
+	}
+	return count;
+}
+
+struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev,
+						       unsigned int supported_rotations)
+{
+	static const struct drm_prop_enum_list props[] = {
+		{ DRM_ROTATE_0,   "rotate-0" },
+		{ DRM_ROTATE_90,  "rotate-90" },
+		{ DRM_ROTATE_180, "rotate-180" },
+		{ DRM_ROTATE_270, "rotate-270" },
+		{ DRM_REFLECT_X,  "reflect-x" },
+		{ DRM_REFLECT_Y,  "reflect-y" },
+	};
+
+	return drm_property_create_bitmask(dev, 0, "rotation",
+					   props, bits_set(supported_rotations),
+					   supported_rotations);
+}
+EXPORT_SYMBOL(drm_mode_create_rotation_property);
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 41b86d2..4b3ac70 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1183,6 +1183,8 @@ extern int drm_format_plane_cpp(uint32_t format, int plane);
 extern int drm_format_horz_chroma_subsampling(uint32_t format);
 extern int drm_format_vert_chroma_subsampling(uint32_t format);
 extern const char *drm_get_format_name(uint32_t format);
+extern struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev,
+							      unsigned int supported_rotations);
 
 /* Helpers */
 static inline struct drm_crtc *drm_crtc_find(struct drm_device *dev,
-- 
1.8.5


  parent reply	other threads:[~2014-02-07 13:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 13:45 [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 02/11] drm: Add support_bits parameter to drm_property_create_bitmask() sagar.a.kamble
2014-02-09 13:37   ` Rob Clark
2014-02-07 13:45 ` sagar.a.kamble [this message]
2014-02-07 13:45 ` [PATCH v4 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sagar.a.kamble
2014-02-09 13:34   ` Rob Clark
2014-02-07 13:45 ` [PATCH v4 05/11] drm: Add drm_rect rotation functions sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 06/11] drm: Add drm_rotation_simplify() sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 07/11] drm/i915: Add 180 degree sprite rotation support sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 08/11] drm/i915: Make intel_plane_restore() return an error sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 09/11] drm/i915: Add rotation property for sprites sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 10/11] drm/i915: Add 180 degree primary plane rotation support sagar.a.kamble
2014-02-07 13:45 ` [PATCH v4 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping sagar.a.kamble
2014-02-07 15:04 ` [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes Daniel Vetter
2014-02-10 10:41 ` One Thousand Gnomes
2014-02-10 13:52   ` Ville Syrjälä
2014-02-10 14:14     ` One Thousand Gnomes
2014-02-10 14:29       ` Ville Syrjälä
2014-02-10 17:31         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391780716-21896-4-git-send-email-sagar.a.kamble@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=archit@ti.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vijay.a.purushothaman@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®