From: Steven Whitehouse <swhiteho@redhat.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
josh@joshtriplett.org
Subject: Re: [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c
Date: Mon, 10 Feb 2014 12:30:20 +0000 [thread overview]
Message-ID: <1392035420.2726.16.camel@menhir> (raw)
In-Reply-To: <ea8cd448204387985f76078b8649168baaf81ab4.1391949868.git.rashika.kheria@gmail.com>
Hi,
On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote:
> Mark functions as static in gfs2/rgrp.c because they are not used
> outside this file.
>
> This eliminates the following warning in gfs2/rgrp.c:
> fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes]
> fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
> fs/gfs2/rgrp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Now in the GFS2 -nmw tree. Thanks,
Steve.
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index a1da213..551b9e9 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd)
> * Returns: errno
> */
>
> -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> {
> struct gfs2_sbd *sdp = rgd->rd_sbd;
> struct gfs2_glock *gl = rgd->rd_gl;
> @@ -1169,7 +1169,7 @@ fail:
> return error;
> }
>
> -int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> {
> u32 rl_flags;
>
next prev parent reply other threads:[~2014-02-10 12:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 12:46 [PATCH 01/21] fs: Remove unused function in afs/write.c Rashika Kheria
2014-02-09 12:49 ` [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04 ` Josh Triplett
2014-02-09 12:52 ` [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 20:56 ` Jens Axboe
2014-02-09 13:00 ` [PATCH 04/21] fs: Add prototype declaration to appropriate header file include/linux/bio.h Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 13:01 ` [PATCH 05/21] fs: Mark function as static in exofs/super.c Rashika Kheria
2014-02-13 17:58 ` Boaz Harrosh
2014-02-13 18:01 ` Rashika Kheria
2014-02-09 13:03 ` [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c Rashika Kheria
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:10 ` [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30 ` Steven Whitehouse [this message]
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
2014-02-09 13:12 ` [PATCH 12/21] fs: Include appropriate header file in notify/fdinfo.c Rashika Kheria
2014-02-09 13:14 ` [PATCH 13/21] fs: Mark functions as static in ocfs2/ioctl.c Rashika Kheria
2014-02-09 13:15 ` [PATCH 14/21] fs: Mark functions as static in ocfs2/journal.c Rashika Kheria
2014-02-09 13:16 ` [PATCH 15/21] fs: Mark function as static in ocfs2/xattr.c Rashika Kheria
2014-02-09 13:17 ` [PATCH 16/21] fs: Mark function as static in ocfs2/cluster/heartbeat.c Rashika Kheria
2014-02-09 13:18 ` [PATCH 17/21] fs: Mark function as static in proc/array.c Rashika Kheria
2014-02-09 13:19 ` [PATCH 18/21] fs: Include appropriate header file in proc/proc_tty.c Rashika Kheria
2014-02-09 13:28 ` [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h Rashika Kheria
2014-02-10 4:02 ` Josh Triplett
2014-02-11 22:44 ` Andrew Morton
2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria
2014-02-09 13:33 ` [PATCH 21/21] fs: Move prototype declaration to appropriate header file Rashika Kheria
2014-02-11 22:36 ` Andrew Morton
2014-02-09 18:08 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Jeff Mahoney
2014-02-13 16:06 ` [PATCH 01/21] fs: Remove unused function in afs/write.c David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392035420.2726.16.camel@menhir \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®