From: Andrew Morton <akpm@linux-foundation.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>,
Michael Holzheu <holzheu@linux.vnet.ibm.com>,
James Hogan <james.hogan@imgtec.com>,
Qais Yousef <qais.yousef@imgtec.com>,
josh@joshtriplett.org
Subject: Re: [PATCH 21/21] fs: Move prototype declaration to appropriate header file
Date: Tue, 11 Feb 2014 14:36:24 -0800 [thread overview]
Message-ID: <20140211143624.277f72655ba9d0fe732fede9@linux-foundation.org> (raw)
In-Reply-To: <94bd5f839212612524d7b8dc2d6a6d4ed96b42da.1391952682.git.rashika.kheria@gmail.com>
On Sun, 9 Feb 2014 19:03:54 +0530 Rashika Kheria <rashika.kheria@gmail.com> wrote:
> Move prototype declaration to header file include/linux/crash_dump.h
It adds a prototype rather than moving it.
> because it is used by more than file.
True, but you didn't notice the second user ;)
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -25,6 +25,7 @@ extern int __weak remap_oldmem_pfn_range(struct vm_area_struct *vma,
>
> extern ssize_t copy_oldmem_page(unsigned long, char *, size_t,
> unsigned long, int);
> +void vmcore_cleanup(void);
>
> /* Architecture code defines this if there are other possible ELF
> * machine types, e.g. on bi-arch capable hardware. */
Take a look over in powerpc...
From: Andrew Morton <akpm@linux-foundation.org>
Subject: include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
clean up powerpc, remove unneeded EXPORT_SYMBOL
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Rashika Kheria <rashika.kheria@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/powerpc/include/asm/fadump.h | 1 -
fs/proc/vmcore.c | 1 -
2 files changed, 2 deletions(-)
--- a/arch/powerpc/include/asm/fadump.h~include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
+++ a/arch/powerpc/include/asm/fadump.h
@@ -210,7 +210,6 @@ extern int is_fadump_active(void);
extern void crash_fadump(struct pt_regs *, const char *);
extern void fadump_cleanup(void);
-extern void vmcore_cleanup(void);
#else /* CONFIG_FA_DUMP */
static inline int is_fadump_active(void) { return 0; }
static inline void crash_fadump(struct pt_regs *regs, const char *str) { }
--- a/fs/proc/vmcore.c~include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
+++ a/fs/proc/vmcore.c
@@ -1118,4 +1118,3 @@ void vmcore_cleanup(void)
}
free_elfcorebuf();
}
-EXPORT_SYMBOL_GPL(vmcore_cleanup);
_
next prev parent reply other threads:[~2014-02-11 22:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 12:46 [PATCH 01/21] fs: Remove unused function in afs/write.c Rashika Kheria
2014-02-09 12:49 ` [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04 ` Josh Triplett
2014-02-09 12:52 ` [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 20:56 ` Jens Axboe
2014-02-09 13:00 ` [PATCH 04/21] fs: Add prototype declaration to appropriate header file include/linux/bio.h Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 13:01 ` [PATCH 05/21] fs: Mark function as static in exofs/super.c Rashika Kheria
2014-02-13 17:58 ` Boaz Harrosh
2014-02-13 18:01 ` Rashika Kheria
2014-02-09 13:03 ` [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c Rashika Kheria
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:10 ` [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30 ` Steven Whitehouse
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
2014-02-09 13:12 ` [PATCH 12/21] fs: Include appropriate header file in notify/fdinfo.c Rashika Kheria
2014-02-09 13:14 ` [PATCH 13/21] fs: Mark functions as static in ocfs2/ioctl.c Rashika Kheria
2014-02-09 13:15 ` [PATCH 14/21] fs: Mark functions as static in ocfs2/journal.c Rashika Kheria
2014-02-09 13:16 ` [PATCH 15/21] fs: Mark function as static in ocfs2/xattr.c Rashika Kheria
2014-02-09 13:17 ` [PATCH 16/21] fs: Mark function as static in ocfs2/cluster/heartbeat.c Rashika Kheria
2014-02-09 13:18 ` [PATCH 17/21] fs: Mark function as static in proc/array.c Rashika Kheria
2014-02-09 13:19 ` [PATCH 18/21] fs: Include appropriate header file in proc/proc_tty.c Rashika Kheria
2014-02-09 13:28 ` [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h Rashika Kheria
2014-02-10 4:02 ` Josh Triplett
2014-02-11 22:44 ` Andrew Morton
2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria
2014-02-09 13:33 ` [PATCH 21/21] fs: Move prototype declaration to appropriate header file Rashika Kheria
2014-02-11 22:36 ` Andrew Morton [this message]
2014-02-09 18:08 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Jeff Mahoney
2014-02-13 16:06 ` [PATCH 01/21] fs: Remove unused function in afs/write.c David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211143624.277f72655ba9d0fe732fede9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qais.yousef@imgtec.com \
--cc=rashika.kheria@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®