From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c
Date: Sun, 9 Feb 2014 18:59:38 -0800 [thread overview]
Message-ID: <20140210025938.GD9176@birch.djwong.org> (raw)
In-Reply-To: <b13f571ff87a2ee1942578a97b00823373e9bd79.1391949868.git.rashika.kheria@gmail.com>
On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in jbd2/journal.c because they are not used
> outside this file.
>
> This eliminates the following warning in jbd2/journal.c:
> fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Looks fine to me, so you can add
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/jbd2/journal.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 5fa344a..244b6f6 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
> #endif
>
> /* Checksumming functions */
> -int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb)
> return cpu_to_be32(csum);
> }
>
> -int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> return sb->s_checksum == jbd2_superblock_csum(j, sb);
> }
>
> -void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> +static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-10 2:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 12:46 [PATCH 01/21] fs: Remove unused function in afs/write.c Rashika Kheria
2014-02-09 12:49 ` [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04 ` Josh Triplett
2014-02-09 12:52 ` [PATCH 03/21] fs: Mark function as static in fs/bio-integrity.c Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 20:56 ` Jens Axboe
2014-02-09 13:00 ` [PATCH 04/21] fs: Add prototype declaration to appropriate header file include/linux/bio.h Rashika Kheria
2014-02-09 13:05 ` Josh Triplett
2014-02-09 13:01 ` [PATCH 05/21] fs: Mark function as static in exofs/super.c Rashika Kheria
2014-02-13 17:58 ` Boaz Harrosh
2014-02-13 18:01 ` Rashika Kheria
2014-02-09 13:03 ` [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c Rashika Kheria
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:10 ` [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30 ` Steven Whitehouse
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong [this message]
2014-02-12 17:36 ` Theodore Ts'o
2014-02-09 13:12 ` [PATCH 12/21] fs: Include appropriate header file in notify/fdinfo.c Rashika Kheria
2014-02-09 13:14 ` [PATCH 13/21] fs: Mark functions as static in ocfs2/ioctl.c Rashika Kheria
2014-02-09 13:15 ` [PATCH 14/21] fs: Mark functions as static in ocfs2/journal.c Rashika Kheria
2014-02-09 13:16 ` [PATCH 15/21] fs: Mark function as static in ocfs2/xattr.c Rashika Kheria
2014-02-09 13:17 ` [PATCH 16/21] fs: Mark function as static in ocfs2/cluster/heartbeat.c Rashika Kheria
2014-02-09 13:18 ` [PATCH 17/21] fs: Mark function as static in proc/array.c Rashika Kheria
2014-02-09 13:19 ` [PATCH 18/21] fs: Include appropriate header file in proc/proc_tty.c Rashika Kheria
2014-02-09 13:28 ` [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h Rashika Kheria
2014-02-10 4:02 ` Josh Triplett
2014-02-11 22:44 ` Andrew Morton
2014-02-09 13:29 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Rashika Kheria
2014-02-09 13:33 ` [PATCH 21/21] fs: Move prototype declaration to appropriate header file Rashika Kheria
2014-02-11 22:36 ` Andrew Morton
2014-02-09 18:08 ` [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c Jeff Mahoney
2014-02-13 16:06 ` [PATCH 01/21] fs: Remove unused function in afs/write.c David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210025938.GD9176@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=josh@joshtriplett.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®