[PATCH] Staging: comedi: Fix coding style issue in poc.c

[PATCH] Staging: comedi: Fix coding style issue in poc.c

[David Roddick]

This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl 

Signed-off-by: David Roddick <dgroddick@gmail.com>
---
 drivers/staging/comedi/drivers/poc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++ b/drivers/staging/comedi/drivers/poc.c
@@ -36,15 +36,15 @@ Configuration options:
 struct boarddef_struct {
 	const char *name;
 	unsigned int iosize;
-	int (*setup) (struct comedi_device *);
+	int (*setup)(struct comedi_device *);
 	int type;
 	int n_chan;
 	int n_bits;
-	int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
+	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
 		      struct comedi_insn *, unsigned int *);
-	int (*rinsn) (struct comedi_device *, struct comedi_subdevice *,
+	int (*rinsn)(struct comedi_device *, struct comedi_subdevice *,
 		      struct comedi_insn *, unsigned int *);
-	int (*insnbits) (struct comedi_device *, struct comedi_subdevice *,
+	int (*insnbits)(struct comedi_device *, struct comedi_subdevice *,
 			 struct comedi_insn *, unsigned int *);
 	const struct comedi_lrange *range;
 };
-- 
1.8.5.3

Re: [PATCH] Staging: comedi: Fix coding style issue in poc.c

[Joe Perches]

On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote:
> This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl 

A few comments:

Please wrap your commit message to 70 columns or so.

There is 1 c in unnecessary.

The "This is a patch to " bit isn't particularly useful in
the commit log, neither is the "found with checkpatch.pl".

> diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c
[]
> @@ -36,15 +36,15 @@ Configuration options:
[]
> -	int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
> +	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
>  		      struct comedi_insn *, unsigned int *);

Please wrap multi-line definitions lines like:

	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
		     struct comedi_insn *, unsigned int *);

Ideally, these arguments would have some descriptive names
too.