From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>, Don Zickus <dzickus@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 4/6] perf tools: Add machine pointer into thread struct
Date: Tue, 18 Mar 2014 15:46:54 +0100 [thread overview]
Message-ID: <1395154016-26709-5-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1395154016-26709-1-git-send-email-jolsa@redhat.com>
Need machine pointer in thread object, so we could
lookup the process thread in following patch.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
tools/perf/util/machine.c | 2 +-
tools/perf/util/thread.c | 4 +++-
tools/perf/util/thread.h | 5 ++++-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index d1f06d2..237d7c2 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -311,7 +311,7 @@ static struct thread *__machine__findnew_thread(struct machine *machine,
if (!create)
return NULL;
- th = thread__new(pid, tid);
+ th = thread__new(pid, tid, machine);
if (th != NULL) {
rb_link_node(&th->rb_node, parent, p);
rb_insert_color(&th->rb_node, &machine->threads);
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index bacf60b..cbe451a 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -8,13 +8,15 @@
#include "debug.h"
#include "comm.h"
-struct thread *thread__new(pid_t pid, pid_t tid)
+struct thread *thread__new(pid_t pid, pid_t tid,
+ struct machine *machine)
{
char *comm_str;
struct comm *comm;
struct thread *thread = zalloc(sizeof(*thread));
if (thread != NULL) {
+ thread->machine = machine;
thread->pid_ = pid;
thread->tid = tid;
thread->ppid = -1;
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index b3f7d8e..21521e1 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -7,12 +7,14 @@
#include <sys/types.h>
#include "symbol.h"
#include <strlist.h>
+#include "machine.h"
struct thread {
union {
struct rb_node rb_node;
struct list_head node;
};
+ struct machine *machine;
struct map_groups *mg;
pid_t pid_; /* Not all tools update this */
pid_t tid;
@@ -29,7 +31,8 @@ struct thread {
struct machine;
struct comm;
-struct thread *thread__new(pid_t pid, pid_t tid);
+struct thread *thread__new(pid_t pid, pid_t tid,
+ struct machine *machine);
void thread__delete(struct thread *thread);
static inline void thread__exited(struct thread *thread)
{
--
1.8.3.1
next prev parent reply other threads:[~2014-03-18 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 14:46 [PATCH 0/6] perf tools: Share map groups within process Jiri Olsa
2014-03-18 14:46 ` [PATCH 1/6] perf tests: Add thread maps lookup automated tests Jiri Olsa
2014-03-18 14:46 ` [PATCH 2/6] perf tools: Remove thread__find_map function Jiri Olsa
2014-03-19 13:08 ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-03-18 14:46 ` [PATCH 3/6] perf tools: Allocate thread map_groups dynamically Jiri Olsa
2014-03-18 14:46 ` Jiri Olsa [this message]
2014-03-18 14:46 ` [PATCH 5/6] perf tools: Share process map groups within process threads Jiri Olsa
2014-03-18 14:46 ` [PATCH 6/6] perf tests: Add map groups sharing with thread object test Jiri Olsa
2014-03-18 19:14 ` [PATCH 0/6] perf tools: Share map groups within process Don Zickus
2014-03-19 0:46 ` Namhyung Kim
2014-03-20 8:33 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395154016-26709-5-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®