mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>, Don Zickus <dzickus@redhat.com>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 6/6] perf tests: Add map groups sharing with thread object test
Date: Tue, 18 Mar 2014 15:46:56 +0100	[thread overview]
Message-ID: <1395154016-26709-7-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1395154016-26709-1-git-send-email-jolsa@redhat.com>

This test create 2 processes abstractions, with several threads
and checks they properly share and maintain map groups info.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
 tools/perf/Makefile.perf           |   1 +
 tools/perf/tests/builtin-test.c    |   4 ++
 tools/perf/tests/tests.h           |   1 +
 tools/perf/tests/thread-mg-share.c | 110 +++++++++++++++++++++++++++++++++++++
 4 files changed, 116 insertions(+)
 create mode 100644 tools/perf/tests/thread-mg-share.c

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 667e85a..ffa6cac 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -415,6 +415,7 @@ LIB_OBJS += $(OUTPUT)tests/dwarf-unwind.o
 endif
 endif
 LIB_OBJS += $(OUTPUT)tests/mmap-thread-lookup.o
+LIB_OBJS += $(OUTPUT)tests/thread-mg-share.o
 
 BUILTIN_OBJS += $(OUTPUT)builtin-annotate.o
 BUILTIN_OBJS += $(OUTPUT)builtin-bench.o
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index d947d1a..a1145d1 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -128,6 +128,10 @@ static struct test {
 		.func = test__mmap_thread_lookup,
 	},
 	{
+		.desc = "Test thread mg sharing",
+		.func = test__thread_mg_share,
+	},
+	{
 		.func = NULL,
 	},
 };
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index 6db764c..5ed3bd5 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -42,6 +42,7 @@ int test__keep_tracking(void);
 int test__parse_no_sample_id_all(void);
 int test__dwarf_unwind(void);
 int test__mmap_thread_lookup(void);
+int test__thread_mg_share(void);
 
 #if defined(__x86_64__) || defined(__i386__)
 #ifdef HAVE_DWARF_UNWIND_SUPPORT
diff --git a/tools/perf/tests/thread-mg-share.c b/tools/perf/tests/thread-mg-share.c
new file mode 100644
index 0000000..43cbd8b
--- /dev/null
+++ b/tools/perf/tests/thread-mg-share.c
@@ -0,0 +1,110 @@
+#include "tests.h"
+#include "machine.h"
+#include "thread.h"
+#include "map.h"
+
+int test__thread_mg_share(void)
+{
+	struct machines machines;
+	struct machine *machine;
+
+	/* thread group */
+	struct thread *leader;
+	struct thread *t1, *t2, *t3;
+	struct map_groups *mg;
+	struct map_groups *mg1, *mg2, *mg3;
+
+	/* other process */
+	struct thread *other, *other_leader;
+	struct map_groups *mg_other, *mg_other_leader;
+
+	/*
+	 * This test create 2 processes abstractions (struct thread)
+	 * with several threads and checks they properly share and
+	 * maintain map groups info (struct map_groups).
+	 *
+	 * thread group (pid: 0, tids: 0, 1, 2, 3)
+	 * other  group (pid: 4, tids: 4, 5)
+	*/
+
+	machines__init(&machines);
+	machine = &machines.host;
+
+	/* create process with 4 threads */
+	leader = machine__findnew_thread(machine, 0, 0);
+	t1     = machine__findnew_thread(machine, 0, 1);
+	t2     = machine__findnew_thread(machine, 0, 2);
+	t3     = machine__findnew_thread(machine, 0, 3);
+
+	/* and create 1 separated process, without thread leader */
+	other  = machine__findnew_thread(machine, 4, 5);
+
+	TEST_ASSERT_VAL("failed to create threads",
+			leader && t1 && t2 && t3 && other);
+
+	/* requests map groups for each thread in the group */
+	mg  = thread__map_groups_get(leader);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 1);
+
+	mg1 = thread__map_groups_get(t1);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 2);
+
+	mg2 = thread__map_groups_get(t2);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 3);
+
+	mg3 = thread__map_groups_get(t3);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 4);
+
+	/* test the map groups pointer is shared */
+	TEST_ASSERT_VAL("map groups don't match", mg == mg1);
+	TEST_ASSERT_VAL("map groups don't match", mg == mg2);
+	TEST_ASSERT_VAL("map groups don't match", mg == mg3);
+
+	/*
+	 * Now get map groups for other thread (not thread leader)
+	 * Its refcnt should be 2 because of the thread leader being
+	 * included.
+	 */
+	mg_other = thread__map_groups_get(other);
+	TEST_ASSERT_VAL("wrong refcnt", mg_other->refcnt == 2);
+
+	/*
+	 * Verify the other leader was created by previous call.
+	 * It should have shared map groups with no change in
+	 * refcnt.
+	 */
+	other_leader = machine__find_thread(machine, 4, 4);
+	TEST_ASSERT_VAL("failed to find other leader", other_leader);
+
+	mg_other_leader = thread__map_groups_get(other_leader);
+	TEST_ASSERT_VAL("map groups don't match", mg_other_leader == mg_other);
+	TEST_ASSERT_VAL("wrong refcnt", mg_other_leader->refcnt == 2);
+
+	/* release thread group */
+	thread__map_groups_put(leader);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 3);
+	TEST_ASSERT_VAL("wrong mg", leader->mg == NULL);
+
+	thread__map_groups_put(t1);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 2);
+	TEST_ASSERT_VAL("wrong mg", t1->mg == NULL);
+
+	thread__map_groups_put(t2);
+	TEST_ASSERT_VAL("wrong refcnt", mg->refcnt == 1);
+	TEST_ASSERT_VAL("wrong mg", t2->mg == NULL);
+
+	thread__map_groups_put(t3);
+	TEST_ASSERT_VAL("wrong mg", t3->mg == NULL);
+
+	/* release other group  */
+	thread__map_groups_put(other_leader);
+	TEST_ASSERT_VAL("wrong refcnt", mg_other_leader->refcnt == 1);
+	TEST_ASSERT_VAL("wrong mg", other_leader->mg == NULL);
+
+	thread__map_groups_put(other);
+	TEST_ASSERT_VAL("wrong mg", other->mg == NULL);
+
+	machine__delete_threads(machine);
+	machines__exit(&machines);
+	return 0;
+}
-- 
1.8.3.1


  parent reply	other threads:[~2014-03-18 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 14:46 [PATCH 0/6] perf tools: Share map groups within process Jiri Olsa
2014-03-18 14:46 ` [PATCH 1/6] perf tests: Add thread maps lookup automated tests Jiri Olsa
2014-03-18 14:46 ` [PATCH 2/6] perf tools: Remove thread__find_map function Jiri Olsa
2014-03-19 13:08   ` [tip:perf/core] " tip-bot for Jiri Olsa
2014-03-18 14:46 ` [PATCH 3/6] perf tools: Allocate thread map_groups dynamically Jiri Olsa
2014-03-18 14:46 ` [PATCH 4/6] perf tools: Add machine pointer into thread struct Jiri Olsa
2014-03-18 14:46 ` [PATCH 5/6] perf tools: Share process map groups within process threads Jiri Olsa
2014-03-18 14:46 ` Jiri Olsa [this message]
2014-03-18 19:14 ` [PATCH 0/6] perf tools: Share map groups within process Don Zickus
2014-03-19  0:46 ` Namhyung Kim
2014-03-20  8:33 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395154016-26709-7-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®