mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simo Sorce <ssorce@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: vgoyal@redhat.com, luto@amacapital.net, tj@kernel.org,
	dwalsh@redhat.com, linux-kernel@vger.kernel.org,
	lpoetter@redhat.com, cgroups@vger.kernel.org, kay@redhat.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: Implement SO_PASSCGROUP to enable passing cgroup path
Date: Thu, 24 Apr 2014 20:29:41 -0400	[thread overview]
Message-ID: <1398385781.2628.452.camel@willson.li.ssimo.org> (raw)
In-Reply-To: <20140424.171155.806959282091051918.davem@davemloft.net>

On Thu, 2014-04-24 at 17:11 -0400, David Miller wrote:
> From: Vivek Goyal <vgoyal@redhat.com>
> Date: Thu, 24 Apr 2014 17:04:29 -0400
> 
> > Does it really matter.
> 
> Good question, if it doesn't matter, you might as well log garbage.
> 
> There are a lot of logical holes in this discussion.
> 
> Real UIDs are always reported at sendmsg() time, not effective ones
> (the UID "at sendmsg() time").
> 
> Therefore if we were to add CGROUP passing at sendmsg() time it should
> report the "real cgroup", the one the task has at the time the file
> descriptor / socket was "created".

Given we are creating a new interface ... should we just send both the
cgroup at creation time and (optionally, if it differs) the cgroup the
process has at sendmsg() time, and let the peer sort out which one it is
interested in ?

Simo.


  reply	other threads:[~2014-04-25  0:29 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 21:15 [PATCH 0/2] net: Implement SO_PEERCGROUP and SO_PASSCGROUP socket options Vivek Goyal
2014-04-15 21:15 ` [PATCH 1/2] net: Implement SO_PEERCGROUP Vivek Goyal
2014-04-15 21:54   ` Andy Lutomirski
2014-04-16  0:22     ` Vivek Goyal
2014-04-15 21:15 ` [PATCH 2/2] net: Implement SO_PASSCGROUP to enable passing cgroup path Vivek Goyal
2014-04-15 21:53   ` Andy Lutomirski
2014-04-15 23:09     ` Simo Sorce
2014-04-16  0:20     ` Vivek Goyal
2014-04-16  1:05       ` David Miller
2014-04-16  3:47       ` Andy Lutomirski
2014-04-16 10:17         ` Vivek Goyal
2014-04-16 14:34           ` Andy Lutomirski
2014-04-16 15:10             ` Vivek Goyal
2014-04-16 12:57         ` David Miller
2014-04-16 14:37           ` Andy Lutomirski
2014-04-16 16:13             ` Simo Sorce
2014-04-16 16:21               ` Tejun Heo
2014-04-16 16:54                 ` Simo Sorce
2014-04-16 16:31               ` Andy Lutomirski
2014-04-16 17:02                 ` Simo Sorce
2014-04-16 17:29                   ` Andy Lutomirski
2014-04-16 17:34                     ` Simo Sorce
2014-04-16 17:53                       ` Andy Lutomirski
2014-04-16 18:36                     ` Vivek Goyal
2014-04-16 18:40                       ` Andy Lutomirski
2014-04-16 18:51                         ` Vivek Goyal
2014-04-16 18:59                           ` Andy Lutomirski
2014-04-16 18:06                 ` Vivek Goyal
2014-04-16 18:13                   ` Andy Lutomirski
2014-04-16 18:25                     ` Vivek Goyal
2014-04-16 18:35                       ` Andy Lutomirski
2014-04-16 19:06                         ` Vivek Goyal
2014-04-16 19:13                           ` Andy Lutomirski
2014-04-16 19:39                             ` Vivek Goyal
2014-04-16 20:24                               ` Andy Lutomirski
2014-04-17 13:41                                 ` Vivek Goyal
2014-04-16 18:59                     ` Vivek Goyal
2014-04-17 15:41                       ` Daniel J Walsh
2014-04-17 16:04                         ` Simo Sorce
2014-04-17 16:11                           ` Andy Lutomirski
2014-04-17 16:24                             ` Simo Sorce
2014-04-17 16:37                               ` Andy Lutomirski
2014-04-17 16:48                                 ` Simo Sorce
2014-04-17 16:55                                   ` Andy Lutomirski
2014-04-17 17:12                                     ` Vivek Goyal
2014-04-17 17:26                                       ` Andy Lutomirski
2014-04-17 17:33                                         ` Simo Sorce
2014-04-17 17:35                                           ` Andy Lutomirski
2014-04-17 17:47                                             ` Simo Sorce
2014-04-17 18:05                                               ` Andy Lutomirski
2014-04-17 18:23                                             ` Simo Sorce
2014-04-17 18:33                                               ` Andy Lutomirski
2014-04-17 18:50                                               ` Vivek Goyal
2014-04-17 18:57                                                 ` Vivek Goyal
2014-04-17 19:06                                                   ` Andy Lutomirski
2014-04-17 19:15                                                     ` Simo Sorce
2014-04-17 19:19                                                       ` Andy Lutomirski
2014-04-17 19:10                                                 ` Simo Sorce
2014-04-17 19:16                                                   ` Vivek Goyal
2014-04-17 19:46                                                     ` Andy Lutomirski
2014-04-21 15:03                                                       ` Vivek Goyal
2014-04-21 15:47                                                         ` Andy Lutomirski
2014-04-23 15:07                                                           ` Vivek Goyal
2014-04-23 15:37                                                             ` Andy Lutomirski
2014-04-23 16:01                                                               ` Vivek Goyal
2014-04-17 19:23                                                 ` Andy Lutomirski
2014-04-17 17:52                                         ` Simo Sorce
2014-04-17 18:04                                           ` Andy Lutomirski
2014-04-17 18:31                                             ` Simo Sorce
2014-04-17 16:38                             ` Vivek Goyal
2014-04-17 16:05                         ` Andy Lutomirski
2014-04-17 16:12                         ` Vivek Goyal
2014-04-23 16:45         ` Vivek Goyal
2014-04-23 17:29           ` David Miller
2014-04-24 20:34             ` Vivek Goyal
2014-04-24 20:48               ` David Miller
2014-04-24 21:04                 ` Vivek Goyal
2014-04-24 21:11                   ` David Miller
2014-04-25  0:29                     ` Simo Sorce [this message]
2014-04-22 20:05 ` [PATCH 0/2] net: Implement SO_PEERCGROUP and SO_PASSCGROUP socket options David Miller
2014-04-22 20:08   ` Andy Lutomirski
2014-04-22 20:29     ` David Miller
2014-04-22 20:31       ` Andy Lutomirski
2014-04-22 20:32         ` David Miller
2014-04-23  0:37           ` Andy Lutomirski
2014-04-23 19:05         ` Vivek Goyal
2014-04-23 20:53           ` Daniel J Walsh
2014-04-24 13:01             ` Vivek Goyal
2014-04-23 15:55   ` Vivek Goyal
2014-04-23 16:16     ` Vivek Goyal
2014-04-23 17:21     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398385781.2628.452.camel@willson.li.ssimo.org \
    --to=ssorce@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dwalsh@redhat.com \
    --cc=kay@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpoetter@redhat.com \
    --cc=luto@amacapital.net \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome