mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Benjamin Philip" <benjamin.philip495@gmail.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers
Date: Tue, 23 Dec 2025 15:23:56 -0500	[thread overview]
Message-ID: <13d990d2-713d-4e1e-a45e-65b92a1e2fc8@app.fastmail.com> (raw)
In-Reply-To: <CAMEXYWeGqq3_k55u3poOBtUQY3U6CxO1R3O--vjttap_=NCsNQ@mail.gmail.com>

On Tue, Dec 23, 2025, at 2:27 PM, Benjamin Philip wrote:
> Benjamin Philip <benjamin.philip495@gmail.com> writes:
>
>> This commit replaces the uint32_t standard type with preferred u32
>> kernel type, fixing the following checkpatch check:
>>
>> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>>
>> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
>> ---
>>  drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h
>> index 017644323d46..6ea4bceafab2 100644
>> --- a/drivers/platform/x86/lenovo/think-lmi.h
>> +++ b/drivers/platform/x86/lenovo/think-lmi.h
>> @@ -58,19 +58,19 @@ struct tlmi_cert_guids {
>>  #define TLMI_PWDCFG_MODE_MULTICERT 3
>>
>>  struct tlmi_pwdcfg_core {
>> -	uint32_t password_mode;
>> -	uint32_t password_state;
>> -	uint32_t min_length;
>> -	uint32_t max_length;
>> -	uint32_t supported_encodings;
>> -	uint32_t supported_keyboard;
>> +	u32 password_mode;
>> +	u32 password_state;
>> +	u32 min_length;
>> +	u32 max_length;
>> +	u32 supported_encodings;
>> +	u32 supported_keyboard;
>>  };
>>
>>  struct tlmi_pwdcfg_ext {
>> -	uint32_t hdd_user_password;
>> -	uint32_t hdd_master_password;
>> -	uint32_t nvme_user_password;
>> -	uint32_t nvme_master_password;
>> +	u32 hdd_user_password;
>> +	u32 hdd_master_password;
>> +	u32 nvme_user_password;
>> +	u32 nvme_master_password;
>>  };
>>
>>  struct tlmi_pwdcfg {
>> --
>> 2.52.0
>
> I've seemed to have botched the In-Reply-To header for this email
> somehow. Please ignore. Sorry!
>
> -- bp

Looks fine
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark

  reply	other threads:[~2025-12-23 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251223190844.944633-1-benjamin.philip495@gmail.com>
2025-12-23 19:09 ` Benjamin Philip
2025-12-23 19:27   ` Benjamin Philip
2025-12-23 20:23     ` Mark Pearson [this message]
2025-12-23 19:09 [PATCH 0/5] platform/x86: think-lmi: Clean up code style Benjamin Philip
2025-12-23 19:19 ` [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers Benjamin Philip

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13d990d2-713d-4e1e-a45e-65b92a1e2fc8@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=benjamin.philip495@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®